Re: [PATCH 1/4] [gdb/testsuite] Fix duplicates in gdb.fortran/array-{indices, repeat}.exp

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

On Tue, Jun 11, 2024 at 3:10 PM Tom de Vries <tdevries@suse.de> wrote:

> When running test-case gdb.fortran/array-indices.exp on a system without
> fortran compiler, I run into a duplicate:
> ...
> Running /home/vries/gdb/src/gdb/testsuite/gdb.fortran/array-indices.exp ...
> gdb compile failed, default_target_compile: Can't find gfortran.
> UNTESTED: gdb.fortran/array-indices.exp: array-indices.exp
> gdb compile failed, default_target_compile: Can't find gfortran.
> UNTESTED: gdb.fortran/array-indices.exp: array-indices.exp
> DUPLICATE: gdb.fortran/array-indices.exp: array-indices.exp
> ...
>
> Fix this by adding a with_test_prefix at the toplevel.
>
> Likewise in gdb.fortran/array-repeat.exp.
>
>
> Hi,

I can confirm I can reproduce this issue on aarch64 and that your patch is
fixing it
 Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>


make check TESTS=gdb.fortran/array-indices.exp
BEFORE the fix:
gdb compile failed, default_target_compile: Can't find gfortran.
gdb compile failed, default_target_compile: Can't find gfortran.
DUPLICATE: gdb.fortran/array-indices.exp: array-indices.exp

=== gdb Summary ===

# of untested testcases 2
# of duplicate test names 1
/root/build/gdb/gdb version  16.0.50.20240612-git -nw -nx -q -iex "set
height 0" -iex "set width 0" -data-directory /root/build/gdb/data-directory

AFTER;
Running
/root/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.fortran/array-indices.exp
...
gdb compile failed, default_target_compile: Can't find gfortran.
gdb compile failed, default_target_compile: Can't find gfortran.

=== gdb Summary ===

# of untested testcases 2
/root/build/gdb/gdb version  16.0.50.20240612-git -nw -nx -q -iex "set
height 0" -iex "set width 0" -data-directory /root/build/gdb/data-directory