From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2718C3858D39 for ; Wed, 28 Feb 2024 16:55:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2718C3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2718C3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709139341; cv=none; b=lLKgyQN47xd3ONlzunPbKynNL/xhZVkoNGOFAALaHIObOL+98EFV1uB1uIEeiyYF9RYHm2CnHfOGwn94GaaKfe3XHcz16q8K6pQeAYunBrXl1wPNLwKmVdsvfODJdOTqr9ELRg39Krwbq5vBRkhSfUsuAiYZAVphGckvabyAabw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709139341; c=relaxed/simple; bh=v92IJnI2HwzfEPSUwBaNXbds2v8RlaQI9cPzonRhkfw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uWY9gTXSqx3LlrnrbkRieed34njQCB41CHLpR7OpVybl0+uzq586M5S/y15+ST/ljhlcS/lUM6G1H0EzCp3WSbBNBsR4jLy+XYiQSwfVIBQFhqkoPskY8wtw9ZGN5137u/9KLalqKI79Tmu7Z86v9esap/aUVYJN6MbXdTLYd0c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709139339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v92IJnI2HwzfEPSUwBaNXbds2v8RlaQI9cPzonRhkfw=; b=TvjFFMqmBsq3eWWv0N12fe+6uSpai5DsBPZVLwTWY0GHZAFjiaVo3JjZTTCzQ2b+Y5+I7C F3fUvuLnYBUwgD7vKZkKHtfGJ/1ObZ+TnWRfjXfJQJnBc1h/MjvLjwIQJdaQCEo11G4xRD FCsWACPkFWte8T56eS4qW6LENVCPVZ0= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-OX3ScttgMJ62Mh-HEHh9bg-1; Wed, 28 Feb 2024 11:55:38 -0500 X-MC-Unique: OX3ScttgMJ62Mh-HEHh9bg-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-299783294a6so4861719a91.3 for ; Wed, 28 Feb 2024 08:55:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709139337; x=1709744137; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v92IJnI2HwzfEPSUwBaNXbds2v8RlaQI9cPzonRhkfw=; b=aOwaXIS60GiQCOovAKLJkGfMunaea3+uKfPkXJQsDfNSslDKCAI956aV+ascQQQIEz l2SF/fdt6zXEDoYkDtZ8AURl3CNpjTkpAugNFSM+LmYO2WbKkFS/j4opJNPlVik+VbdC on/DTy3dgC9cIQtTOcABt9Plf1x47YMNPhVVdOw3NMQUUv8q5NDW3MUyQTA8O2Zf54jS Tw9cDJ+WE2MHUk+kZQLzoUYxpTUkIaQ+Yog80h4/eL4CxarOVMn7Jdid4Ca++rvTLxSp RKvOFcFaqrJg5gcZX75jj8A1ifo+XqvfkoMCSSZ/mJtQmCXgmBGDebMAk1DzR9YUuVyg WReA== X-Gm-Message-State: AOJu0YxtfGz0U0mhuhzj1x8bR8izweylBpXBrP2I1hSIrOAGMd1dxPwO OkVxJAJg8Hfn2to1t/ZylxjpVZSrc97LPgm5rwW/zCnJLIgLQGYvtY0J5ysbsAgV6rjZeuCO+ch MWnS1xv3YuEJH44svm5xZEHHk38FSlJW7CxJLU0V/pKGxSLiGV3shBo86nIPyybLIp1BkdVJgZO 6eTBlJF/qyFZ+Xwd+P8THAzu80BCiinMfrl1eGPnhj+g== X-Received: by 2002:a17:90a:8d82:b0:29a:1ed5:18a2 with SMTP id d2-20020a17090a8d8200b0029a1ed518a2mr224610pjo.47.1709139336911; Wed, 28 Feb 2024 08:55:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPPOlxfaapP/D8xVoVVD+MkVWNFTU+nL4muMvApqnSRuEXdftHEozLWSlwzyRBJIS8192aH9N3BrErDBctlLU= X-Received: by 2002:a17:90a:8d82:b0:29a:1ed5:18a2 with SMTP id d2-20020a17090a8d8200b0029a1ed518a2mr224601pjo.47.1709139336640; Wed, 28 Feb 2024 08:55:36 -0800 (PST) MIME-Version: 1.0 References: <20240227-obstac-alloc-v1-0-bd079aad35cd@adacore.com> <20240227-obstac-alloc-v1-3-bd079aad35cd@adacore.com> In-Reply-To: <20240227-obstac-alloc-v1-3-bd079aad35cd@adacore.com> From: Alexandra Petlanova Hajkova Date: Wed, 28 Feb 2024 17:55:25 +0100 Message-ID: Subject: Re: [PATCH 3/3] Require trivial destructor in allocate_on_obstack To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000000852210612740384" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,MIME_BOUND_DIGITS_15,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000000852210612740384 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 10:43=E2=80=AFPM Tom Tromey wr= ote: > This patch makes allocate_on_obstack a little bit safer, by enforcing > the rule that objects allocated on an obstack must have a trivial > destructor. > > The static assert is done in a method -- doing it inside the class > itself won't work because the class is incomplete at that point. > --- > > Looks great. I can confirm this change does not cause any regressions for aarch64 Fedora Rawhide. --0000000000000852210612740384--