From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DEFA53858D33 for ; Tue, 7 Feb 2023 05:57:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEFA53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675749444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ME3CCywViVrqGG80bRvwwnDg1csCFHlwnF+bOvQWJWA=; b=bB+KAIgdg0SJwkfbzZLlGi6eZyqaSBv1n+uG3yFM4PlUg/Osp3EeN7qbgw/5tDdaxDxqtZ pPzU68O2HjUPqeNdWG5NRtQv5EimMhbCSUWz9efRWZ/pVOIQHFAN+im+nCgWv5yQbP0LmE ZC+CRspUhEADpKvo2ZiIOOISrAdcWck= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-154-qjvTnw37Mp-iWELAYqwMzg-1; Tue, 07 Feb 2023 00:57:23 -0500 X-MC-Unique: qjvTnw37Mp-iWELAYqwMzg-1 Received: by mail-pg1-f197.google.com with SMTP id 127-20020a630685000000b004ec5996dcc0so6193621pgg.8 for ; Mon, 06 Feb 2023 21:57:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ME3CCywViVrqGG80bRvwwnDg1csCFHlwnF+bOvQWJWA=; b=J122Ti/UrmK2S6yTBrGWeZzyiVs+WBjDlRB4ZFEP7qj5jAjHQGRS6M4vW5V6m+p2Uc zkNqej/eQYKYrYd0gYcdIBbAI1ZekKTigQkaNgl6LN0QA0g37mI+DjGjwiW3wgSvGG+8 dK8Ohdl5Tt7mDkiX6tIB+G7ZpXw6HOO7169vzYFn+hLKECY/99ORW6lyH4sZ27rjLygS 88nR8UJNGjSk9fCb781PIPP3gw8kgzEIPsqTEOxBOUaqofIsKCiHC+0m9jVa1nBPqU1q KZSrWu0PznHEzfzmtPRQMAHxhLaAneYcMBLDRvx2OoYED87piu69VcXJ0nPJc6tL65gg HdLA== X-Gm-Message-State: AO0yUKU54kDgDyR6GQUkoxGMa71dKEgJSEpwYSX1CB3TxDM8W5oWitcF v60vp1nS65pb1Qo0oUlhMzSaanECZfxAtDlrV0Ego8joqfC2kNSP9VWRwkYm/dE/1ji8IqMf+vq n0tR8P/3+VAquwWHEoDb2Z6gdlgj/NVReoVNlTJqA9TE= X-Received: by 2002:aa7:9a0e:0:b0:593:ce65:29ef with SMTP id w14-20020aa79a0e000000b00593ce6529efmr527919pfj.31.1675749441793; Mon, 06 Feb 2023 21:57:21 -0800 (PST) X-Google-Smtp-Source: AK7set/SaViR3hC/QFW5+L8hIANmjTft+LpEnRTbxjBgmVlM+mjR+k/ACHNyK8VZQ4vXI8XFOEgt0hWOIIni7i0090Y= X-Received: by 2002:aa7:9a0e:0:b0:593:ce65:29ef with SMTP id w14-20020aa79a0e000000b00593ce6529efmr527910pfj.31.1675749441161; Mon, 06 Feb 2023 21:57:21 -0800 (PST) MIME-Version: 1.0 References: <20230204162755.2831-1-ed@catmur.uk> In-Reply-To: <20230204162755.2831-1-ed@catmur.uk> From: Alexandra Petlanova Hajkova Date: Tue, 7 Feb 2023 06:57:10 +0100 Message-ID: Subject: Re: [PATCH v2][PR 17272] Support DWARF tags for C++11 variadic templates To: Ed Catmur Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002c6e1e05f415d232" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002c6e1e05f415d232 Content-Type: text/plain; charset="UTF-8" On Sat, Feb 4, 2023 at 5:28 PM Ed Catmur wrote: > This patch adds support for DW_TAG_GNU_formal_parameter_pack and > DW_TAG_GNU_template_parameter_pack, added to DWARF in March 2009 for > C++11 variadic templates[1]. > > They are not currently emitted thanks to a typo[2] but the fix is > trivial[3] and has been repeatedly submitted[4] to gcc; I'm not sure > what else I can do to get it accepted; regardless, anyone building their > own compiler can still make use of this. > > This implementation synthesizes type and parameter names as T#n, p#n > e.g. Args#1, args#1. This is a pretty simple approach but it seems to > work OK and is compatible with the old style type and parameter names > emitted by old versions of gcc and when it's writing stabs+ format, > meaning that any debugger scripts will continue to work. > > 1. http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates > 2. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536 > 3. https://github.com/ecatmur/gcc/pull/5 > 4. https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609659.html > PR. https://sourceware.org/bugzilla/show_bug.cgi?id=17272 > --- > I think this should be accepted. > --0000000000002c6e1e05f415d232--