From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C3F643858D28 for ; Mon, 9 Oct 2023 20:34:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3F643858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696883659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kqi9JAytCRAhz4ThkJoZ+OL7Er9eobS9uKvAdU7LsII=; b=I8X9IvVTWa58mBiye6jWaP4w3W7TPsxYq8zJUIG6vPKFqfi4uSx1oZJmnX6fz3rNxyN35r pNngo1s4iWpucEFYDPAxSiWBhRUPT1uEh+dzMJW1JYZzjyHkjEHtdo9C7ijAAyNGiKoadk loObfZDHMNco7eJu00U4tZ2ihByFyBs= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-sTjadnPiNl2yr-tsho2p5g-1; Mon, 09 Oct 2023 16:34:07 -0400 X-MC-Unique: sTjadnPiNl2yr-tsho2p5g-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-27cdee6909bso205108a91.0 for ; Mon, 09 Oct 2023 13:34:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696883646; x=1697488446; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kqi9JAytCRAhz4ThkJoZ+OL7Er9eobS9uKvAdU7LsII=; b=cwojOFcC9w40AvcAHzy5pK03u/6yJH9lhh8H4pYvwCfut3REmg6Q7AVrmIm/D42lb2 XxBhsi4Lddsm63zRKFE88UwBdvNGRmvbODm8VVtSmLeyv4Cvg//1AFv7Spl2u5H6RLQf BZeJGsmOJm6NJAswKdXtcih+epkzNlxRGFGwVt40F2pIN6cma/1KZzqTMWqj2f1jQAsh JjVbEo4JywKuE2rnDPSLRRWCAqK87ldOpyLICAvEGkj0CmPp6ibSyJflGaQrxVJ3H4AW YbhM4wspSZpOoHgvqah+2UI3B/sFAkRO4I0xG2qjEr0kElF1a0D2a0n8G7dXTTYkNji4 A9nQ== X-Gm-Message-State: AOJu0YwANzM7Ji7Pp1QQX+eFQmDrfy2GPsVhV8jlCijb+3DvY6yL/Vlh KJU5RKQZHSUXRpssKPiyKduvUtnVPEm+77oXQZ2DjpyGvC3vRTCDfgQMIFJliISDfuQRhsR03wR J1tB0GdV85bFYCujZ4jEGFQ0b01Ek/RPmiR16Jw== X-Received: by 2002:a17:90b:895:b0:279:47d0:d92a with SMTP id bj21-20020a17090b089500b0027947d0d92amr14070009pjb.17.1696883645893; Mon, 09 Oct 2023 13:34:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZuG3wZf25Lafgpza9YDKdxq9FX97WpM5P2n0m2iLegZSFbklrgC2uCWAG15P/kUaN+4nU6S0zi6YF9HGgq4Q= X-Received: by 2002:a17:90b:895:b0:279:47d0:d92a with SMTP id bj21-20020a17090b089500b0027947d0d92amr14069997pjb.17.1696883645604; Mon, 09 Oct 2023 13:34:05 -0700 (PDT) MIME-Version: 1.0 References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-2-tdevries@suse.de> In-Reply-To: <20231002125051.29911-2-tdevries@suse.de> From: Alexandra Petlanova Hajkova Date: Mon, 9 Oct 2023 22:33:54 +0200 Message-ID: Subject: Re: [PATCH 01/13] [gdb/symtab] Factor out m_die_range_map usage To: Tom de Vries Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ebfaba06074e827e" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ebfaba06074e827e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 2, 2023 at 2:53=E2=80=AFPM Tom de Vries via Gdb-patches < gdb-patches@sourceware.org> wrote: > Factor out usage of cooked_indexer::m_die_range_map into new class > parent_map > with member functions find_parent and set_parent. > > Tested on x86_64-linux. > --- > gdb/dwarf2/cooked-index.h | 22 ++++++++++++++++++++++ > gdb/dwarf2/read.c | 23 +++++++++++++++++------ > 2 files changed, 39 insertions(+), 6 deletions(-) > > > It seems breakpoint-locs.exp test does not fail anymore with this patch applied on ppc64le Fedora Rawhide. But I wouldn't expect that from just a factoring out. Is that a coincidence? < Breakpoint 1 at 0x10010208: file /root/build/gdb/testsuite/../../../binutils-g db/gdb/testsuite/gdb.cp/breakpoint-locs.h, line 23. < (gdb) FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz < testcase /root/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/breakp= oint-locs.exp completed in 0 seconds --- > Breakpoint 1 at 0x10010208: N1::C1::baz. (2 locations) > (gdb) PASS: gdb.cp/breakpoint-locs.exp: break N1::C1::baz > testcase /root/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/breakp= oint-locs.exp completed in 1 seconds --000000000000ebfaba06074e827e--