From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 63B89384F02E for ; Mon, 20 Mar 2023 11:55:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63B89384F02E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679313311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a171uGaNiW5m9sQPsiWEoPjf+rWmnRDi0Wk/mJHpXgo=; b=A/tlwds5ykkQHSSzou6gDApG8BWrE6IRpvggLPHIAGjutIIViuFG5fLnXbUxiiaiY8Igmi 21VgVT0RAhRDttNw6OMHBrxN1xPORhxLE8SP6EPv3WC1KvX22z4bBTMLEYuofhY3jLdOWy jQ9sXERpteCajfu9N4YnIWcuJp6TDAs= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-SURa9SolPSe-5nQgKnYBAg-1; Mon, 20 Mar 2023 07:55:07 -0400 X-MC-Unique: SURa9SolPSe-5nQgKnYBAg-1 Received: by mail-pl1-f197.google.com with SMTP id l10-20020a17090270ca00b0019caa6e6bd1so6983490plt.2 for ; Mon, 20 Mar 2023 04:55:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679313306; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a171uGaNiW5m9sQPsiWEoPjf+rWmnRDi0Wk/mJHpXgo=; b=AkSjMkMvW8GR18nFPMNoH+G/RPyf2vyb7C4xjANM/CIG6IWD4GWNfJ4SoNgfKZsAsD lWL2vN8Yi9c+yaCwsn2OtlyTOZwL6a7jdrgbBKQW69iW1e9WJ6/sY5L3w7Mu1TnYh5tP 8drLkVzc0EJR9H4aiAp9WIoFDTwEymdg3/1CjIbx/HXye1QueVNhovqxg49WQTdAIFdx H1e8xYVOrzueoIRNoW9eJFybD2heGRQG/5Xht1VeQqww6A/eAfqcH4S2xVzniMTzn330 uJq+dFWOEADnjo7F+0NxvXRah/mnBQgGhBAjFHiEqvQoJnjWIICm5/PgjQKcwejPXHuX n6rg== X-Gm-Message-State: AO0yUKXxgxwcpiHbmvOzD4eenwvm2ZsbMvAQcIuSg/8x2N0Ftp5wivKq M9SYl2yCyt6YUSoI4z98HvKZK82PqI1/rYbSCPVlFmng5cKavkhlTVz4G0rV2FNlykBMonhn7ES gvIKKNbDwnDSdLcv6vdIZ5jdQitFChBRm9eZy6JqqDtnsKw== X-Received: by 2002:a05:6a00:2da:b0:625:ccb1:5da1 with SMTP id b26-20020a056a0002da00b00625ccb15da1mr6119798pft.2.1679313306496; Mon, 20 Mar 2023 04:55:06 -0700 (PDT) X-Google-Smtp-Source: AK7set98IOv9CDqEuXBUN85z/GEaaZgGMf/7nw7LZCI+3q04Tb0cr/p6NIgHa48RT4LFZ+ozCOMB1lhBpgW6MTpkalI= X-Received: by 2002:a05:6a00:2da:b0:625:ccb1:5da1 with SMTP id b26-20020a056a0002da00b00625ccb15da1mr6119792pft.2.1679313306205; Mon, 20 Mar 2023 04:55:06 -0700 (PDT) MIME-Version: 1.0 References: <20230313180100.2728620-1-christina.schimpe@intel.com> <20230313180100.2728620-2-christina.schimpe@intel.com> In-Reply-To: <20230313180100.2728620-2-christina.schimpe@intel.com> From: Alexandra Petlanova Hajkova Date: Mon, 20 Mar 2023 12:54:55 +0100 Message-ID: Subject: Re: [PATCH 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command To: Christina Schimpe Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000015591405f7539907" X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000015591405f7539907 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 13, 2023 at 7:01=E2=80=AFPM Christina Schimpe via Gdb-patches < gdb-patches@sourceware.org> wrote: > From: Nils-Christian Kempke > > The ERROR_NO_INFERIOR macro is already called at the beginning of the > function. Since target/inferior are not switched in-between, the second > call to it is redundant. > > Co-Authored-By: Christina Schimpe > --- > gdb/infcmd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index c369b795757..abe9c933c9a 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty) > } > } > > - ERROR_NO_INFERIOR; > ensure_not_tfind_mode (); > > if (!non_stop || !all_threads_p) > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > Looks correct. Maybe you could mention this happens inside the continue_command function in the commit message. --00000000000015591405f7539907--