Re: [PATCH] Remove error_stream

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On Sun, Apr 16, 2023 at 8:49 PM Tom Tromey <tom@tromey.com> wrote:

> error_stream is trivial and only used in a couple of spots in
> breakpoint.c.  This patch removes it in favor of just writing it out
> at the spots where it was used.
> ---
>  gdb/breakpoint.c | 4 ++--
>  gdb/utils.c      | 6 ------
>  gdb/utils.h      | 2 --
>  3 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 46287da5f87..baf49e4461f 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -3137,7 +3137,7 @@ update_inserted_breakpoint_locations (void)
>    if (error_flag)
>      {
>        target_terminal::ours_for_output ();
> -      error_stream (tmp_error_stream);
> +      error (("%s"), tmp_error_stream.c_str ());
>
> I was considering using it in my "defer warnings when loading separate
debug file" but it wasn't suitable, it seems it doesn't have many use cases
indeed.