From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Rename tui-stack -> tui-status
Date: Wed, 13 Dec 2023 14:35:31 +0100 [thread overview]
Message-ID: <CAJVr-EOfVQibvGdLe0Exn5tPTBgOe9_UMB5MZ+6ij4tBcnzbyQ@mail.gmail.com> (raw)
In-Reply-To: <20231208-tui-status-rename-v1-1-db019efd7483@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Fri, Dec 8, 2023 at 6:43 PM Tom Tromey <tom@tromey.com> wrote:
> The TUI status line is called the "status" window in the
> documentation, but not in the source. There, the relevant files are
> named "tui-stack", which to me makes it sound like they have something
> to do with backtraces. This patch renames them to "tui-status".
>
>
Hi,
this patch does not compile for me with:
./../binutils-gdb/gdb/tui/tui-data.c:29:10: fatal error: tui/tui-stack.h:
No such file or directory
29 | #include "tui/tui-stack.h"
| ^~~~~~~~~~~~~~~~~
Have you forgotten to modify tui-data.c?
next prev parent reply other threads:[~2023-12-13 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 17:43 [PATCH 0/2] Rename TUI status code to follow the docs Tom Tromey
2023-12-08 17:43 ` [PATCH 1/2] Rename tui-stack -> tui-status Tom Tromey
2023-12-13 13:35 ` Alexandra Petlanova Hajkova [this message]
2023-12-13 20:00 ` Tom Tromey
2023-12-08 17:43 ` [PATCH 2/2] Rename TUI locator window -> status Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJVr-EOfVQibvGdLe0Exn5tPTBgOe9_UMB5MZ+6ij4tBcnzbyQ@mail.gmail.com \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).