On Sun, Feb 26, 2023 at 8:00 PM Tom Tromey <tom@tromey.com> wrote:

> OBJF_REORDERED is set for nearly every object format.  And, despite
> the ominous warnings here and there, it does not seem very expensive.
> This patch removes the flag entirely.
> ---
>  gdb/buildsym.c      | 20 ++++++++------------
>  gdb/coffread.c      |  5 -----
>  gdb/elfread.c       |  4 ----
>  gdb/machoread.c     |  4 +---
>  gdb/mdebugread.c    | 29 -----------------------------
>  gdb/objfile-flags.h | 22 +++++++---------------
>  gdb/psymtab.c       |  3 +--
>  gdb/symfile.c       |  2 +-
>  gdb/symtab.c        | 17 +++++------------
>  gdb/xcoffread.c     |  5 -----
>  10 files changed, 23 insertions(+), 88 deletions(-)
>
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index dbc81727cb1..8b6cb616d71 100644
>
>
I think it's a nice simplification and a reasonable thing to do.