From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 057933858D33 for ; Tue, 28 Feb 2023 11:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 057933858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677583369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CnGinSbc2FYCYod0rfKa4FHeF3oz4vfZ+U13zGQenys=; b=XpzVMsZeN8iXZyi/rqM4FKDy/LnZqdR4v4sbX7hlvjPexiB2SA7grTknO9F1lvF1XSaJmM daBVoAQRLY0Tdh2XN4DFmK8+w2vPrc4shL2CGX5J0M9Tbtac1HM6zWUs52BAXJ5joofab4 udELT1ussJePQI53MIEh8r6Bs/aBSCk= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-637-kWZGGX6lPvKk3TvXX3dzPg-1; Tue, 28 Feb 2023 06:22:48 -0500 X-MC-Unique: kWZGGX6lPvKk3TvXX3dzPg-1 Received: by mail-pg1-f198.google.com with SMTP id e127-20020a636985000000b004bbc748ca63so3218402pgc.3 for ; Tue, 28 Feb 2023 03:22:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CnGinSbc2FYCYod0rfKa4FHeF3oz4vfZ+U13zGQenys=; b=0oBXoPZHHa0zBKe5UIhE4WKeJSiLXp4ohMxzBbZCnCZqCQ37CnCG35kxkZvantbvks x5XUMZGmetaYHmGr67mZSK7QakyV18SJUp3CD/wEN3eDxtlrVBpdo2p3RdOS6Iy7AN5l kwDL4NsNNSNMmmjb10gtinKfSMfecY/HQFt3IjfJs0XMKygOjzXOk52JHccOs8xqINVd XCqt+Qwg/W8u8Tz3GFEbfBvvFeraZTDNFlgFxs4LlJAf44UqGsbxt6de0iWKzQPiAbqf mgcPMujvhuQEpy9yzv3NqkqnefX8fm0fLm/6tMNllSipHx/FxHMvl4Ig3NWoL0gSEOFN W2Ww== X-Gm-Message-State: AO0yUKWhWQmM3rQhaWf3F9E+q2GhvfoAVrGuoFOHeUCj4v4tHusKhztW KVdpfh/3Q8UDBjA/6QbcMbLMtEwhrCypezJcOtZPQ7uHOi82q6XNK72h6DwrxzLPASwXEcxOFzo Z+krVu6jDu4Ju2eYUyuSylkQrGozA4bXfWPuM9Zuq54o= X-Received: by 2002:a05:6a00:1c86:b0:5a8:daec:c325 with SMTP id y6-20020a056a001c8600b005a8daecc325mr5800735pfw.1.1677583366561; Tue, 28 Feb 2023 03:22:46 -0800 (PST) X-Google-Smtp-Source: AK7set8bUQge/or34IsG3zB3XY9lgS6NssF8g5jU8n7MjW97sIqqPPtD+1oliS9pR5kxgT/EwQ4DEcQ1ulgibRb7s5E= X-Received: by 2002:a05:6a00:1c86:b0:5a8:daec:c325 with SMTP id y6-20020a056a001c8600b005a8daecc325mr5800728pfw.1.1677583366271; Tue, 28 Feb 2023 03:22:46 -0800 (PST) MIME-Version: 1.0 References: <20230226185808.2677822-1-tom@tromey.com> In-Reply-To: <20230226185808.2677822-1-tom@tromey.com> From: Alexandra Petlanova Hajkova Date: Tue, 28 Feb 2023 12:22:35 +0100 Message-ID: Subject: Re: [PATCH] Remove OBJF_REORDERED To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000a0cd6205f5c0d083" X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a0cd6205f5c0d083 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 26, 2023 at 8:00 PM Tom Tromey wrote: > OBJF_REORDERED is set for nearly every object format. And, despite > the ominous warnings here and there, it does not seem very expensive. > This patch removes the flag entirely. > --- > gdb/buildsym.c | 20 ++++++++------------ > gdb/coffread.c | 5 ----- > gdb/elfread.c | 4 ---- > gdb/machoread.c | 4 +--- > gdb/mdebugread.c | 29 ----------------------------- > gdb/objfile-flags.h | 22 +++++++--------------- > gdb/psymtab.c | 3 +-- > gdb/symfile.c | 2 +- > gdb/symtab.c | 17 +++++------------ > gdb/xcoffread.c | 5 ----- > 10 files changed, 23 insertions(+), 88 deletions(-) > > diff --git a/gdb/buildsym.c b/gdb/buildsym.c > index dbc81727cb1..8b6cb616d71 100644 > > I think it's a nice simplification and a reasonable thing to do. --000000000000a0cd6205f5c0d083--