From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E09BF3858D32 for ; Mon, 2 Jan 2023 15:37:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672673846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7IVX/5M0GuO+1AbuJxFWmndj7OmYhvTHEq6Gm2zUHsc=; b=AHJpeQ1V/oJQFPWoGvEBGUfPeM3cS550UQNGw84Fi/9vjwOlBksXUkcJ4YjcqWN+ZVTwrb K7oQk35Es9UbES6pDg+GRIGNqXIqBVPH3XvYYr15c+In14NQ1QQ44owlM4Gise8m7pcrVu T6Zs5z5lzqqoan3SE4ebagL8MTY/7RE= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-227-VXEY-xvwNTG88PNLPvi4_w-1; Mon, 02 Jan 2023 10:37:25 -0500 X-MC-Unique: VXEY-xvwNTG88PNLPvi4_w-1 Received: by mail-pf1-f197.google.com with SMTP id j1-20020aa78001000000b0057d28e11cb6so13098161pfi.11 for ; Mon, 02 Jan 2023 07:37:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7IVX/5M0GuO+1AbuJxFWmndj7OmYhvTHEq6Gm2zUHsc=; b=SB2ZAW9oXyAX8wtUZ/HxKOEdAeoNj0VMGTY3B4xubf2Qeq96uCUodp2xIrdGaqsVpi L3pphpKOwF/xwYB8d6x39UujBfc+inMbhzzj/Aj4g4vpwZm8lOKsg2zB80TishHzcxcz 7DP0pAvhJcODU7VPdt9E9pMToVZfRAMMbUPJtJE32WYkhO77Zu9zIhCy8yFABzZIQwox xFHG7fFz79NQLmsJ2RCDERAHNceKK4QrHw/xabZNwzmNIwV4+Lal05x/GWoeBAe4SofA elC/KrPdvkdycwQ7FFwsfDnVzZ3EEJLHt09vgUsrXveJtmuafLuUlyF4KkiKX13VZcOA aZ6w== X-Gm-Message-State: AFqh2ko03JSTPBVpoJyQim0uWErPEDj/QIWOU22Y/EmqTDPCoOjB+kYf hGiiIU+AYCJjxu+lkWwMtdBYiRKu9RMyU1IXOb1LIcvUKTpF9SFF/p3vZTKO8SQwqNKnczypdnm 5W/hL7DUvF+/OlTCAFAYjb+sxKtVUncR2DGWyUA== X-Received: by 2002:a17:903:32c8:b0:189:e149:a1af with SMTP id i8-20020a17090332c800b00189e149a1afmr2101704plr.18.1672673843739; Mon, 02 Jan 2023 07:37:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4bjW/q815VgEq2APFFh+qAP3KciqU2vU5Qs6Lpc/vPiuVdIFUC0lWZT1HHESpHI29bhqwmOcQSM7eeH40tQU= X-Received: by 2002:a17:903:32c8:b0:189:e149:a1af with SMTP id i8-20020a17090332c800b00189e149a1afmr2101697plr.18.1672673843094; Mon, 02 Jan 2023 07:37:23 -0800 (PST) MIME-Version: 1.0 References: <20221222154338.2223678-1-blarsen@redhat.com> In-Reply-To: <20221222154338.2223678-1-blarsen@redhat.com> From: Alexandra Petlanova Hajkova Date: Mon, 2 Jan 2023 16:37:11 +0100 Message-ID: Subject: Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command To: Bruno Larsen Cc: gdb-patches@sourceware.org, Eli Zaretskii X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003eba2f05f149bada" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003eba2f05f149bada Content-Type: text/plain; charset="UTF-8" > +# This file is part of the GDB testsuite. it tests the functionality of > +# the maintenance print record-instruction command, but does not check the > +# syntax, only if the command finds or fails to find recorded history. > + > +if ![supports_reverse] { > + return > +} > + > I think this patch is good to go in general. But it might be nice to add a small summary about how the test works as a comment at the beginning of the test? Regards, Alexandra --0000000000003eba2f05f149bada--