From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: gdb-patches@sourceware.org
Subject: Fwd: [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line
Date: Thu, 15 Dec 2022 14:26:14 +0100 [thread overview]
Message-ID: <CAJVr-EP0kU10W5LD3QpZdZtdi2fkdzd=ATNL+d1aW4AHKt5YbA@mail.gmail.com> (raw)
In-Reply-To: <CAJVr-EMEbyP4pgDk=U50p5nWrybJgFbdZ0iLCp4W6WbWJKGc9A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Tue, Nov 22, 2022 at 12:52 PM Bruno Larsen via Gdb-patches <
gdb-patches@sourceware.org> wrote:
>
>
> Finally, because the final test of gdb.cp/nsusing.exp has turned into
> multiple that all would need XFAILs for older GCCs (<= 4.3), and that
> GCC is very old, if it is detected, the test just exits early.
>
I suggest using shorter sentences in general and I think the last sentence
needs
to be split in two. I had to read it 3 times to fully understand it.
>
> --
> 2.38.1
>
> I can confirm the patch applies cleanly on top of master and doesn't seem
to add new
failures to make check runs.
next prev parent reply other threads:[~2022-12-15 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:33 [PATCH v3 0/2] Improve handling of using directives Bruno Larsen
2022-11-22 11:33 ` [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line Bruno Larsen
[not found] ` <CAJVr-EMEbyP4pgDk=U50p5nWrybJgFbdZ0iLCp4W6WbWJKGc9A@mail.gmail.com>
2022-12-15 13:26 ` Alexandra Petlanova Hajkova [this message]
2022-12-15 14:50 ` Fwd: " Bruno Larsen
2022-12-20 21:06 ` Tom Tromey
2022-11-22 11:33 ` [PATCH v3 2/2] gdb/c++: Detect ambiguous variables in imported namespaces Bruno Larsen
2022-12-20 21:10 ` Tom Tromey
2022-12-07 13:53 ` [PATCH v3 0/2] Improve handling of using directives Bruno Larsen
2022-12-15 10:17 ` [PINGv2][PATCH " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-EP0kU10W5LD3QpZdZtdi2fkdzd=ATNL+d1aW4AHKt5YbA@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).