Fwd: [PATCH] gdb: defer warnings when loading separate debug files

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

>
> I don't really like this behavior change.  The situations you described:
>
>  - a separate debug file without any actual debug information
>  - CRC checksum that doesn't match
>
> ... are abnormal situations which still deserve being warned about, I
> think.  If the files are there, it's because they are meant to be used,
> so if something prevents GDB from using them, I want to know.  Silencing
> the warning just makes investigating "why doesn't GDB read my separate
> debug file" harder.
>
> I can understand why this can be a bit confusing to the user, but
> the warning is still factually correct.  For instance, the one you
> quoted:
>
>     warning: the debug information found in
> "/usr/lib/debug//lib64/ld-2.32.so.debug"
>     does not match "/lib64/ld-linux-x86-64.so.2" (CRC mismatch).
>
> This doesn't say that GDB didn't end up finding *some* debug info for
> the shared object, just that this particular one is broken.  Maybe it's
> an old one I installed by hand, that I should delete, maybe the package
> from the distro is broken.  In any case it's good for the user to know
> so they can fix the situation.
>
> Simon
>
> Yes, it's a good point. It might be confusing to see the warnings if the
correct debuginfo was retrieved but it might be useful to see all the
warnings
on the other hand. I would love to have more opinions on this matter.

Thank you,
Alexandra