From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 022D93853832 for ; Fri, 21 Oct 2022 10:50:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 022D93853832 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-408-_Ir-23iSMn2nLQgcPNm2EQ-1; Fri, 21 Oct 2022 06:50:34 -0400 X-MC-Unique: _Ir-23iSMn2nLQgcPNm2EQ-1 Received: by mail-pl1-f198.google.com with SMTP id b2-20020a170902d50200b001866035cb0aso1465346plg.8 for ; Fri, 21 Oct 2022 03:50:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cNiArRwUj3Zp6mBDTo0G5m+A4jhVOS84XoKqbppZPlY=; b=dhUkc9EcvnQ9+S0Jr95l43stN+Lr3b4bxXYhADJbn5S/D4sG1Sn9ltS/A/+W1+RY5l e6reAf1C98Uoz0n335ivXqeR41qGkBxwi/rRjlY2u+pMV/t+6/3Rlnpq4RJFr+ASD6P9 AVd1o4S8se6ZKe1DWIwC56rgVHoM1w13Vhf71dizyePSyh5g5x1fPdAxJomEKotPdflU lyEiyxB5ZAlmaSu7JEd1Hps/QgFdu5LjiWO4+HJmdOs6YIqGoGLLPvATdCYOmM2iL2kL OhFbYPmZGAIH0Xfp47AUWnGO2Dc2W5WoNNjIlMhwfjl0x/+LwyyZDxBulV397wF7o+97 P0Gg== X-Gm-Message-State: ACrzQf3+ncP7mQBAzgNq7iEKqkFxqUdJM27W8xM/8qg2KKtuRv/UyhFe auj7fnjxjYDfsL1WqvH/nucgDe216eVGkinxqf7Gyrde0AlCsQgrxdl2PmL6rbUgChYe2CQjgMg O3ON6jp5Z4AOYuStiw3K1ZrxCJPNvwdoWnC9oAg== X-Received: by 2002:a17:90a:3841:b0:20b:650:60d1 with SMTP id l1-20020a17090a384100b0020b065060d1mr21173577pjf.102.1666349432668; Fri, 21 Oct 2022 03:50:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6RA2/YwlmCx47Xwp3q7O4fSXI8O1U1g8xrHd4uzdWRQ23H4fIb4qrn37c9OZBsAtziZlsQQ9nCA4+Ji+rdubU= X-Received: by 2002:a17:90a:3841:b0:20b:650:60d1 with SMTP id l1-20020a17090a384100b0020b065060d1mr21173551pjf.102.1666349432425; Fri, 21 Oct 2022 03:50:32 -0700 (PDT) MIME-Version: 1.0 References: <20221017193858.3006-1-asaffisher.dev@gmail.com> <20221017193858.3006-3-asaffisher.dev@gmail.com> In-Reply-To: <20221017193858.3006-3-asaffisher.dev@gmail.com> From: Alexandra Petlanova Hajkova Date: Fri, 21 Oct 2022 12:50:21 +0200 Message-ID: Subject: Re: [PATCH 2/2] Make GDB resolve dlopen of memory mapped shared libraries To: Asaf Fisher Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 10:50:37 -0000 On Mon, Oct 17, 2022 at 9:39 PM Asaf Fisher via Gdb-patches < gdb-patches@sourceware.org> wrote: > Introduced `check_proc_self_file` that checks if a path used by > inferior in dlopen is in the form of `/proc/self/...` and if so resolves > it to `/proc/[pid]/...` > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29586 > --- > gdb/solib-svr4.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 56 insertions(+), 2 deletions(-) > > diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c > index 7e83819a03d..231a4fb40e5 100644 > --- a/gdb/solib-svr4.c > +++ b/gdb/solib-svr4.c > @@ -34,6 +34,7 @@ > #include "regcache.h" > #include "gdbthread.h" > #include "observable.h" > +#include "gdbsupport/pathstuff.h" > > #include "solist.h" > #include "solib.h" > @@ -46,6 +47,9 @@ > #include "gdb_bfd.h" > #include "probe.h" > > Looks correct to me. I can confirm gdb.base/solib-proc-self.exp test added > by [PATCH 1/2] fails and hangs without this fix and passes after applying it. This patch needs rebase. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 022D93853832 for ; Fri, 21 Oct 2022 10:50:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 022D93853832 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666349435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cNiArRwUj3Zp6mBDTo0G5m+A4jhVOS84XoKqbppZPlY=; b=QVXN1EhoCkEB2Uh8p5jHYFAXeZaHpG3I6eX5XklqHhPLF11koPavZANZIDcjry9KX3f3iK Wboqc+nzvZtT9O0rN37qDcb2iR585rt7dPcGuDfSX0FiJcFsDuzOX0FVGlZOzm3o8ATzlG l0AqG23mx50QtElF/wayiYT/9UVMw3A= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-408-_Ir-23iSMn2nLQgcPNm2EQ-1; Fri, 21 Oct 2022 06:50:34 -0400 X-MC-Unique: _Ir-23iSMn2nLQgcPNm2EQ-1 Received: by mail-pl1-f198.google.com with SMTP id b2-20020a170902d50200b001866035cb0aso1465346plg.8 for ; Fri, 21 Oct 2022 03:50:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cNiArRwUj3Zp6mBDTo0G5m+A4jhVOS84XoKqbppZPlY=; b=dhUkc9EcvnQ9+S0Jr95l43stN+Lr3b4bxXYhADJbn5S/D4sG1Sn9ltS/A/+W1+RY5l e6reAf1C98Uoz0n335ivXqeR41qGkBxwi/rRjlY2u+pMV/t+6/3Rlnpq4RJFr+ASD6P9 AVd1o4S8se6ZKe1DWIwC56rgVHoM1w13Vhf71dizyePSyh5g5x1fPdAxJomEKotPdflU lyEiyxB5ZAlmaSu7JEd1Hps/QgFdu5LjiWO4+HJmdOs6YIqGoGLLPvATdCYOmM2iL2kL OhFbYPmZGAIH0Xfp47AUWnGO2Dc2W5WoNNjIlMhwfjl0x/+LwyyZDxBulV397wF7o+97 P0Gg== X-Gm-Message-State: ACrzQf3+ncP7mQBAzgNq7iEKqkFxqUdJM27W8xM/8qg2KKtuRv/UyhFe auj7fnjxjYDfsL1WqvH/nucgDe216eVGkinxqf7Gyrde0AlCsQgrxdl2PmL6rbUgChYe2CQjgMg O3ON6jp5Z4AOYuStiw3K1ZrxCJPNvwdoWnC9oAg== X-Received: by 2002:a17:90a:3841:b0:20b:650:60d1 with SMTP id l1-20020a17090a384100b0020b065060d1mr21173577pjf.102.1666349432668; Fri, 21 Oct 2022 03:50:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6RA2/YwlmCx47Xwp3q7O4fSXI8O1U1g8xrHd4uzdWRQ23H4fIb4qrn37c9OZBsAtziZlsQQ9nCA4+Ji+rdubU= X-Received: by 2002:a17:90a:3841:b0:20b:650:60d1 with SMTP id l1-20020a17090a384100b0020b065060d1mr21173551pjf.102.1666349432425; Fri, 21 Oct 2022 03:50:32 -0700 (PDT) MIME-Version: 1.0 References: <20221017193858.3006-1-asaffisher.dev@gmail.com> <20221017193858.3006-3-asaffisher.dev@gmail.com> In-Reply-To: <20221017193858.3006-3-asaffisher.dev@gmail.com> From: Alexandra Petlanova Hajkova Date: Fri, 21 Oct 2022 12:50:21 +0200 Message-ID: Subject: Re: [PATCH 2/2] Make GDB resolve dlopen of memory mapped shared libraries To: Asaf Fisher Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000fdeb8005eb893508" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221021105021.YCbhFwYbT8Kk-ptOuZEzl3K0GGZSH-uiQ9C6xdxi9Mo@z> --000000000000fdeb8005eb893508 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 17, 2022 at 9:39 PM Asaf Fisher via Gdb-patches < gdb-patches@sourceware.org> wrote: > Introduced `check_proc_self_file` that checks if a path used by > inferior in dlopen is in the form of `/proc/self/...` and if so resolves > it to `/proc/[pid]/...` > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29586 > --- > gdb/solib-svr4.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 56 insertions(+), 2 deletions(-) > > diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c > index 7e83819a03d..231a4fb40e5 100644 > --- a/gdb/solib-svr4.c > +++ b/gdb/solib-svr4.c > @@ -34,6 +34,7 @@ > #include "regcache.h" > #include "gdbthread.h" > #include "observable.h" > +#include "gdbsupport/pathstuff.h" > > #include "solist.h" > #include "solib.h" > @@ -46,6 +47,9 @@ > #include "gdb_bfd.h" > #include "probe.h" > > Looks correct to me. I can confirm gdb.base/solib-proc-self.exp test added > by [PATCH 1/2] fails and hangs without this fix and passes after applying it. This patch needs rebase. --000000000000fdeb8005eb893508--