From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] Rename tui-stack -> tui-status
Date: Thu, 21 Dec 2023 14:24:09 +0100 [thread overview]
Message-ID: <CAJVr-EPHU7bdRtvyQ+SKddXN15+pTZmGCifNw0HiL2kuG6q9Yg@mail.gmail.com> (raw)
In-Reply-To: <20231213-tui-status-rename-v2-1-e87cbf6d1d2b@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Wed, Dec 13, 2023 at 9:03 PM Tom Tromey <tom@tromey.com> wrote:
> The TUI status line is called the "status" window in the
> documentation, but not in the source. There, the relevant files are
> named "tui-stack", which to me makes it sound like they have something
> to do with backtraces. This patch renames them to "tui-status".
> ---
> gdb/Makefile.in | 4 ++--
> gdb/tui/tui-data.c | 2 +-
> gdb/tui/tui-disasm.c | 2 +-
> gdb/tui/tui-hooks.c | 2 +-
> gdb/tui/tui-layout.c | 2 +-
> gdb/tui/tui-location.c | 2 +-
> gdb/tui/tui-source.c | 2 +-
> gdb/tui/{tui-stack.c => tui-status.c} | 2 +-
> gdb/tui/{tui-stack.h => tui-status.h} | 0
> gdb/tui/tui-win.c | 2 +-
> gdb/tui/tui-wingeneral.c | 2 +-
> gdb/tui/tui-winsource.c | 2 +-
> gdb/tui/tui.c | 2 +-
> 13 files changed, 13 insertions(+), 13 deletions(-)
>
>
> I can confirm this change is causing no regressions for Fedora Rawhide,
aarch64. Also I agree, tui-status is a better name then tui-stack.
next prev parent reply other threads:[~2023-12-21 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 20:03 [PATCH v2 0/2] Rename TUI status code to follow the docs Tom Tromey
2023-12-13 20:03 ` [PATCH v2 1/2] Rename tui-stack -> tui-status Tom Tromey
2023-12-21 13:24 ` Alexandra Petlanova Hajkova [this message]
2023-12-13 20:03 ` [PATCH v2 2/2] Rename TUI locator window -> status Tom Tromey
2023-12-21 15:37 ` Alexandra Petlanova Hajkova
2023-12-21 23:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJVr-EPHU7bdRtvyQ+SKddXN15+pTZmGCifNw0HiL2kuG6q9Yg@mail.gmail.com \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).