From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1C6EB3858D1E for ; Tue, 24 Jan 2023 15:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C6EB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674574930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HRkU6lJO83htRQQKp/EBPK3YdG4MjBN+DZuBDdc0jaQ=; b=TbB02NjCTPkeJe1jdexkj13HTHYcaeZEBKhCwNtxNVkkVKhTmrS5y+xhujM6xlWvXt/eDH NYzMuHATaCMxiS5Xr4gxOxpi+jCbes7/4RRrpcdEB+U4pYN/kuXeUjn0N6UCaK4VTX+Ju+ Gwmm/+Jqs9+bOJuv+4fbJZ+qYlrOftM= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-540--FSjEzc6MtePcE9oF8nMsw-1; Tue, 24 Jan 2023 10:42:09 -0500 X-MC-Unique: -FSjEzc6MtePcE9oF8nMsw-1 Received: by mail-pf1-f199.google.com with SMTP id l7-20020a62be07000000b0058de3976793so6956534pff.18 for ; Tue, 24 Jan 2023 07:42:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mr6eDemxhnayMbbzD+OexcJ3orZR+JYYit+Uvx0LztE=; b=CgobRG3yudRrvSeZSqZM2tIjzqgi2WxHGWCnv3d8yFMstocfcChwHHCWfrCpcZih7B 6TtDO3jZ3u1D5bCkwL8HDoFF81+qLsF/4zNqAveCUo5SHwlFO6ODeat1YpwOGTsKhfTV QyHtGMqTBHHCpBX5VgUVGMz/CM6itBemnM858jbofmSZcIhCQomDw6n3ZsJJ2RKGyWdK QEMuN7kNaHnRZ4lHvPhrUX78llJLNfOx+ssOsIU1wHAVkz0IlT1ESgf/MUtouiAUa984 B80agJdePrPEiOGM4dhxr7J/h0lODbs8s62HB4QA4gL3DlyjUIMYB1qqYPtu81/XFxRf rDQw== X-Gm-Message-State: AFqh2kq/hb4KuQzUgUutBQBQAHC+rP8hWPmzj6SgGuRsSDN8WC5rv9or a1o8Wi3z+P67QLlYI5XebFTfbOBIHHsoUOaTNV1qRP/2invC8UcCFFyUKT99bFnZ14FGf6+3085 D0uLqoaZIVDmTA4Uu9WBDJHnAMB9X/yqbLZrx+Q== X-Received: by 2002:a05:6a00:f9a:b0:58d:385f:2a10 with SMTP id ct26-20020a056a000f9a00b0058d385f2a10mr2761019pfb.54.1674574927804; Tue, 24 Jan 2023 07:42:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXutNqm2qHC2LxP3JJrTg3MOw/pikmhTP/zrQPnQY5cjDOwQI9t8Hpw85A4vT3SWcbpNd3R42Jfs53uUYeZUaWA= X-Received: by 2002:a05:6a00:f9a:b0:58d:385f:2a10 with SMTP id ct26-20020a056a000f9a00b0058d385f2a10mr2761014pfb.54.1674574927539; Tue, 24 Jan 2023 07:42:07 -0800 (PST) MIME-Version: 1.0 References: <20230123220257.3773828-1-tromey@adacore.com> <20230123220257.3773828-3-tromey@adacore.com> In-Reply-To: <20230123220257.3773828-3-tromey@adacore.com> From: Alexandra Petlanova Hajkova Date: Tue, 24 Jan 2023 16:41:56 +0100 Message-ID: Subject: Re: [PATCH 2/2] Avoid FAILs in gdb.compile To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000b4c92605f3045b21" X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,TXREP,T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b4c92605f3045b21 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 23, 2023 at 11:03 PM Tom Tromey via Gdb-patches < gdb-patches@sourceware.org> wrote: > Many gdb.compile C++ tests fail for me on Fedora 36. I think these > are largely bugs in the plugin, though I didn't investigate too > deeply. Once one failure is seen, this often cascades and sometimes > there are many timeouts. > > For example, this can happen: > > (gdb) compile code var = a->get_var () > warning: Could not find symbol "_ZZ9_gdb_exprP10__gdb_regsE1a" for > compiled module "/tmp/gdbobj-0xdI6U/out2.o". > 1 symbols were missing, cannot continue. > > I think this is probably a plugin bug because, IIRC, in theory these > symbols should be exempt from a lookup via gdb. > > This patch arranges to catch any catastrophic failure and then simply > exit the entire .exp file. > > I think it's great, running make check looks better with this for sure (tried on Fedora 36) < # of expected passes 119003 < # of unexpected failures 6 --- > # of expected passes 119023 > # of unexpected failures 43 I like how you handle unknown _ZZ9_gdb_exprP10__gdb_regsE1a symbol with UNSUPPORTED. gdb) compile code var = a->get_var () warning: Could not find symbol "_ZZ9_gdb_exprP10__gdb_regsE1a" for compiled module "/tmp/gdbobj-Fa9HOp/out2.o". 1 symbols were missing, cannot continue. (gdb) UNSUPPORTED: gdb.compile/compile-cplus-method.exp: GCC compiler plugin bug testcase /home/ahajkova/build/gdb/gdb/testsuite/../../../../binutils-gdb/gdb/testsuite/gdb.compile/compile-cplus-method.exp completed in 1 seconds Running /home/ahajkova/build/gdb/gdb/testsuite/../../../../binutils-gdb/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp ... --000000000000b4c92605f3045b21--