From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/tui] Show focus window in status line
Date: Tue, 28 Nov 2023 16:22:11 +0100 [thread overview]
Message-ID: <CAJVr-EPaWSLN1jHVY1sxb=oQDksAgpLqnb2sm=wGRhC=9_tg7g@mail.gmail.com> (raw)
In-Reply-To: <20231127033908.13249-2-tdevries@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Mon, Nov 27, 2023 at 4:48 AM Tom de Vries <tdevries@suse.de> wrote:
> The focused window is highlighting by using active-border-kind instead of
> border-kind.
>
> But if the focused window is the cmd window (which is an unboxed window),
> then
> no highlighting is done, and it's not obvious from looking at the screen
> which
> window has the focus. Instead, you have to notice the absence of
> highlighting
> on boxed windows, and then infer that the focus is on the unboxed window.
>
> That approach stops working if there are multiple unboxed windows.
>
> Likewise if highlighting is switched off by setting active-border-kind to
> the
> same value as border-kind.
>
> Make it more explicit which window has the focus by mentioning it in the
> status
> window, like so:
> ...
> native process 8282 (src) In: main L7 PC: 0x400525
> ...
>
> Tested on x86_64-linux.
> ---
> I can confirm it works for ppc64le Fedora Rawhide, the (src) is neatly
> there. Causes no regressions.
>
next prev parent reply other threads:[~2023-11-28 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 3:39 [PATCH 1/2] [gdb/tui] Use const std::string for string literals in tui-stack.c Tom de Vries
2023-11-27 3:39 ` [PATCH 2/2] [gdb/tui] Show focus window in status line Tom de Vries
2023-11-28 15:22 ` Alexandra Petlanova Hajkova [this message]
2023-11-28 17:03 ` Tom de Vries
2023-11-28 9:19 ` [PATCH 1/2] [gdb/tui] Use const std::string for string literals in tui-stack.c Alexandra Petlanova Hajkova
2023-11-28 15:34 ` Tom de Vries
2023-11-27 3:45 [PATCH 2/2] [gdb/tui] Show focus window in status line Tom de Vries
2023-12-08 15:37 ` Tom Tromey
2023-12-08 16:51 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-EPaWSLN1jHVY1sxb=oQDksAgpLqnb2sm=wGRhC=9_tg7g@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).