From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8E1373858C2D for ; Mon, 27 Nov 2023 12:16:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E1373858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E1373858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701087378; cv=none; b=brNtO+TpCBoZ5XHaHh1pWIPXH/dt4JVfYYMIUpZkTJBHOd4HT9u9B+nKQli1PVcYitIwjb1UStJIgpsy1wtIZJmPQ4A1WgFkiPEq9BZhjLdM0vVOkmhaY2DUAW2luBe/N3QiHEYKfCI/uyBnf8F3WOogY7c0hbmNcGt3dmZAtZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701087378; c=relaxed/simple; bh=VXhjO1kWbHyFd2OCTkJtOBsmcpHCDd2wWYu8lfoObR4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=NuOCwyNBjxQJ1YbmE4hVy/U9c2fxvfS7XLu0K6RauXi+QFcjbbWW0flcgGfR920QGBzCoENKwppic1RZCAM+5InvrOMBgVfapQApCSPhqnY4xcQ4erxxh5zqLpoQnKpcdLVVkklwKJJ9Cg8971MaRqV1hGioaBYpQWBlcCE6IvI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701087376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GtknOOE/TvK4Z/rhAxE6vmUSLhsL9kPu7hweo7f/9oE=; b=LEiiJvF5HuqbCG1jEvW0ffNXIl+f5osmkYMclQTqqgU0j1AlWLTJBBoH9VPXL8hXC2SCEE IiK/wT4s2AYG6MaeHnsvszXcRydTBbu8rJhbb9KUj/n10tK/cK+3+w+xbqVL7yNU/STo4v rAHb4iR6GjGGH8UWViWhtiZHzWcCSWs= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-fULiZc3FPNC46KmPgubTcg-1; Mon, 27 Nov 2023 07:16:14 -0500 X-MC-Unique: fULiZc3FPNC46KmPgubTcg-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-5bdfc1bb3eeso4958068a12.1 for ; Mon, 27 Nov 2023 04:16:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701087373; x=1701692173; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GtknOOE/TvK4Z/rhAxE6vmUSLhsL9kPu7hweo7f/9oE=; b=oGxsRyf5XtkDR+Y+Il2oLcgARBq4leXNumxTpoyrCoGboFixsomtTW6hgN1xVqu1zb v802+9M258eB3MQwv8/9dj8hhV8f4GSbxa6ixa6WVBlCXiLHlv6CGH2/FxGPm6idtIub 43i1SNQmWqiLQHHJOlU9QIOy4qfkpEfJGWsrWSoaqecv30MkboJuwg1eT7lwuI/HGqQS Z5N8vWObZErYsGFr3oBOPMpovXRppbxF0ReawWuHuN6rgU5VUifKJd6EEfquc66whdzO OEAUo4h3z+R3vWvQ45LLsLK704jOk2sZjYHa+dKN957uHIwI0wh7D0UcuKNHeKNw4hKN vLGQ== X-Gm-Message-State: AOJu0Yz1r5VYMcOIWoJkrez9Cx/PCwJ9UeendeULGCDGTyVTz/UkEoP4 44rttrhu6yGdl7Bs+27KPKpRWqKaJ8hoR0dQy/zQU8qzI3U1R0DsGTwQycBDxt6z7JkOAIB8avl Nqap+oHDG416Ijrfv+nG7fb2ik3QaGlslEj3bBA== X-Received: by 2002:a17:90b:4b0e:b0:285:b687:b831 with SMTP id lx14-20020a17090b4b0e00b00285b687b831mr8231581pjb.10.1701087373480; Mon, 27 Nov 2023 04:16:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYlmuSTTsNiRTcen0RUsGAFmhIwsC2qyWDsI7SeaVNNZv+eqUvlenYvaG6mloiJnwjn4lVQpjYlWeBwYXVY/E= X-Received: by 2002:a17:90b:4b0e:b0:285:b687:b831 with SMTP id lx14-20020a17090b4b0e00b00285b687b831mr8231550pjb.10.1701087373141; Mon, 27 Nov 2023 04:16:13 -0800 (PST) MIME-Version: 1.0 References: <20231124102710.7681-1-tdevries@suse.de> In-Reply-To: <20231124102710.7681-1-tdevries@suse.de> From: Alexandra Petlanova Hajkova Date: Mon, 27 Nov 2023 13:16:01 +0100 Message-ID: Subject: Re: [PATCH] [gdb/tui] Show regs when switching to regs layout To: Tom de Vries Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009bc1bf060b21448b" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000009bc1bf060b21448b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 24, 2023 at 11:27=E2=80=AFAM Tom de Vries wr= ote: > When starting gdb in CLI mode, running to main and switching into the TUI > regs > layout: > ... > $ gdb -q a.out -ex start -ex "layout regs" > ... > we get: > ... > +---------------------------------+ > | | > | [ Register Values Unavailable ] | > | | > +---------------------------------+ > ... > > Fix this by updating the TUI_DATA_WIN in tui_apply_current_layout. > > Tested on x86_64-linux. > > PR tui/28600 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D28600 > --- > I can confirm I can see this issue on ppc64le Fedora Rawhide and this > patch fixes this. I'm able to see the Register group now > when running "gdb/gdb -q /bin/ls -ex start -ex "layout regs"". I can also confirm this change does not introduce any regressions. --0000000000009bc1bf060b21448b--