On Tue, Feb 27, 2024 at 10:43 PM Tom Tromey wrote: > The addrmap polymorphism is sort of "phony" in that there isn't really > code in the tree that can be presented with either type. I haven't > tried to fix this (though perhaps I may); but meanwhile it's handy for > the next patch if addrmap_fixed has a trivial destructor. This patch > achieves this by making the addrmap destructor non-virtual, and also > making it protected so that objects of any of these types cannot be > destroyed when only the base class is known. > --- > I think it's a reasonable change and I can confirm this change does not introduce any regressions on aarch64 with Fedora Rawhide.