From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E2A3B3858D39 for ; Wed, 28 Feb 2024 15:16:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2A3B3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2A3B3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709133409; cv=none; b=GDa8VsPtAbkP3bgkx+VNgD4Yqu0BE2wouRxNAigIDzf18kAJTM6Lzf36byshYmoeup01WbUgxQlnjHPRSbsjDaohsL8Q3drJLJ+FQAYMNkaB057613OzdwFhZU0BG7i0Cny++37bIgOT3xy6hjV5OgksYQZ7taVo2JEjCTVULT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709133409; c=relaxed/simple; bh=fzLZAXaZw4zz4YG86swAWa653N8r+UkAj5RsaTPPNbY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=VMwCI84SMWjPtJEN76ErJpthSxLzL+aLPSHqCtuKj94HXlZPnSSipiF2a9xCuek4hWJAziViKPfrfKrHJ3Zf+wAOSydQYUu771K1v9sf9ISX97XIXsL4B2EXap0L/5voiVK3nnQ2A1MG66U5Z3uQB592pxyt/rq6xUtJLrLrMms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709133407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jEQFbuAOmQBWLiiV4zZVCivf2nK/txp59RArCl46EwI=; b=IcOpZzwvuWpa821YO6083abTUoknh1zxADs22P4f6ZeRiFzPNUWjqbzxJDs8zw8VqiH+QM knSYDjMmIFzuyrX0D1TC4O3pKIGrNJ+HLAXvmgndurBvzymqygDzS0nWG6n03+pIExAhOF 7TarYombUhgsm9HV6zX8Wc1fbx6FvKc= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-jOzhOVEXOjaT6Wt0JlZ_3w-1; Wed, 28 Feb 2024 10:16:44 -0500 X-MC-Unique: jOzhOVEXOjaT6Wt0JlZ_3w-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-290a26e6482so4997156a91.0 for ; Wed, 28 Feb 2024 07:16:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709133404; x=1709738204; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jEQFbuAOmQBWLiiV4zZVCivf2nK/txp59RArCl46EwI=; b=KHPr7F5Yva9VEw3gVKsD4hxs0sQIYMwLs+ZCOxrpA+KK1pf4g7mFkh2176wmsPe8sP L2YHxeDGoAxgJzyKqiYeAVCCfHezrXG6mUV1I2XxyorM6GcaAEaICqcj3GHZVAvfB8CT /wAy5OMdbc8j8Xf31maOHDYwtJOFY5sQJrisAVbqh/nhYKHVUidQvrv1ffnRzz2K54Rf WxkWgbBbsV7QAI3Z5+7e64U6O5Ex7QC8lx4522i2B73OsOGfgYjJnDsnzum89dPGpac9 kw+S5DJifP1JR3oYTRYRv0RinRowtQvE/EC89wjp7iN06CgztWHSQzzGeW04lsXScSlA D40g== X-Gm-Message-State: AOJu0YytvVv42qU1eNLBJuakPlxiHoLmDbDSovm8aedKRixIZBC5Nfbx zcYWJ0V1sB3JPWsoyXCLUrBJFr4l1zrJ/LAGqqB5PRpVq1OsyIql91NxFsQhHyxO4pWuviBPs1d UuwOqty7dzN3tfXbq5tF1h2T4ymQ96x4tg3Y6qAW5d7Xd5dkCSCSF6ijcSpNl0lNu4i8ZCz+H8m oF0Ls51/qAYJY681Gbqi1UiCkr26tZ16EUUQ== X-Received: by 2002:a17:90a:528e:b0:299:6ee1:592a with SMTP id w14-20020a17090a528e00b002996ee1592amr9394023pjh.47.1709133403859; Wed, 28 Feb 2024 07:16:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUG5AtBks6NoBm4zA8lzHqG9w36Vdrj6lOLAt3zd/OEAFtpRbV6u4Cz37tnAtl/iKkiBbgLhISrtcDuyRQLi0= X-Received: by 2002:a17:90a:528e:b0:299:6ee1:592a with SMTP id w14-20020a17090a528e00b002996ee1592amr9394007pjh.47.1709133403597; Wed, 28 Feb 2024 07:16:43 -0800 (PST) MIME-Version: 1.0 References: <20240227-obstac-alloc-v1-0-bd079aad35cd@adacore.com> <20240227-obstac-alloc-v1-2-bd079aad35cd@adacore.com> In-Reply-To: <20240227-obstac-alloc-v1-2-bd079aad35cd@adacore.com> From: Alexandra Petlanova Hajkova Date: Wed, 28 Feb 2024 16:16:32 +0100 Message-ID: Subject: Re: [PATCH 2/3] Don't use virtual destructor in addrmap To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000654655061272a128" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000654655061272a128 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 10:43=E2=80=AFPM Tom Tromey wr= ote: > The addrmap polymorphism is sort of "phony" in that there isn't really > code in the tree that can be presented with either type. I haven't > tried to fix this (though perhaps I may); but meanwhile it's handy for > the next patch if addrmap_fixed has a trivial destructor. This patch > achieves this by making the addrmap destructor non-virtual, and also > making it protected so that objects of any of these types cannot be > destroyed when only the base class is known. > --- > I think it's a reasonable change and I can confirm this change does not introduce any regressions on aarch64 with Fedora Rawhide. --000000000000654655061272a128--