From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129398 invoked by alias); 1 Mar 2018 13:08:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128515 invoked by uid 89); 1 Mar 2018 13:08:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=you! X-HELO: mail-ua0-f169.google.com Received: from mail-ua0-f169.google.com (HELO mail-ua0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 13:08:08 +0000 Received: by mail-ua0-f169.google.com with SMTP id u99so3800767uau.8 for ; Thu, 01 Mar 2018 05:08:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yBvbF8R0toT0fr5LIieppICCD5wHZoP1DrsaDSwypUE=; b=IL84+l33Yj5FDHRj0cTrvewIOOhlTG8bvBJlRzkN82akg6OI0Ylv11UssaXICwdgU5 ghWWgeaXevnqDGaj2QwocU2z/wTR9WI96romlAEDUq6XPGTBrWpj8gPdwRq6+d4WaicS feHX5pgzBA4JupzZScvZ/r147nhiOTUZoiexEQOo67LdMmkdyb1SFoSpureY3Eq+Ng+R VN1QsshX2DlioZ0ztJAQ4J6LddrteAgJ/5YSy140HJgKW9Os3MTnrei1LAOU1h1MfwJ3 8VZhJAO58x8by6i61utoSlTaKZ1re/g+vfQKSGJeIG4xa7onUZjNI5EAp0MacZWebxeR Kk8w== X-Gm-Message-State: APf1xPBh1RPPfUhgL2mtrP5PsmSvj+36ll7hdzN2lXCuiqmYWCA8l/oD pGbxkQ+fN9iyZSlwB7rM0ihgBk/hCD/46Yl+mVX1Xw== X-Google-Smtp-Source: AG47ELuBBIWkbtEYUQS5O5zbHtdjv6hQ2K66xyLQ+jrZVFMPY//EbVWGiyUeMYmnBz1S1aL06Mwwm5N/0toZlfVDEiA= X-Received: by 10.176.24.161 with SMTP id t33mr1157267uag.198.1519909686035; Thu, 01 Mar 2018 05:08:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.70.28 with HTTP; Thu, 1 Mar 2018 05:08:05 -0800 (PST) In-Reply-To: <20180301025528.zyh5m5jls45t3ooa@adacore.com> References: <20180210014241.19278-3-sergiodj@redhat.com> <20180228032708.19670-1-sergiodj@redhat.com> <87sh9ka5ze.fsf@redhat.com> <20180301025528.zyh5m5jls45t3ooa@adacore.com> From: Christophe Lyon Date: Thu, 01 Mar 2018 13:08:00 -0000 Message-ID: Subject: Re: [PATCH v3 0/2] Make gdbserver work with filename-only binaries To: Joel Brobecker Cc: Sergio Durigan Junior , GDB Patches , Simon Marchi , Pedro Alves Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00019.txt.bz2 On 1 March 2018 at 03:55, Joel Brobecker wrote: >> Simon reminded me that this patch is also a good fit for the 8.1 branch, >> so I went ahead and pushed it there. >> >> 506817a3abd98859eb3474389e756c0253cc28a1 >> 2441702a72f324e41a1624dc042b334f375e2d81 >> 6d607b8812b35ff36fbbad2915696f6669f86a32 > Hi, These new patches seem to cause problems with building for ming (using i686-w64-mingw32-g++): /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr gdb_realpath(const char*)': /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope char buf[MAX_PATH]; ^ /gdb/common/pathstuff.c:57:5: error: 'DWORD' was not declared in this scope DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL); ^ /gdb/common/pathstuff.c:57:11: error: expected ';' before 'len' DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL); ^ /gdb/common/pathstuff.c:63:9: error: 'len' was not declared in this scope if (len > 0 && len < MAX_PATH) ^ /gdb/common/pathstuff.c:64:54: error: 'buf' was not declared in this scope return gdb::unique_xmalloc_ptr (xstrdup (buf)); ^ make[2]: *** [pathstuff.o] Error 1 I saw this while rebuilding branch 8.1, I didn't check master. Sorry if this has already been reported, I can't find any mention of this problem in the list archives. I suspect there's already a recommended way of handling MAX_PATH cross-platform. Thanks Christophe > Thanks for getting this through, Sergio and Simon. > > Just a quick reminder that, now that the .0 is out, all new patches > pushed on the branch should have a corresponding PR number, with > the target milestone set to 8.1. This is to be able to give users > an actionable list of PRs they can look at if they are wondering > what the difference between 8.0 and 8.1 is. Is there one for this > issue? If not, it's good enough to create one after the fact, as > long as the PR points to the various discussions and maybe gives > the SHA1 of the various commits, I think we're good. > > Thank you! > -- > Joel