From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94228 invoked by alias); 17 Apr 2018 15:53:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94214 invoked by uid 89); 17 Apr 2018 15:53:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-34.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED,USER_IN_DEF_SPF_WL autolearn=unavailable version=3.3.2 spammy= X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 15:52:54 +0000 Received: by mail-wr0-f178.google.com with SMTP id l49so36904417wrl.4 for ; Tue, 17 Apr 2018 08:52:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qKArI3lRyO8cr60fy+NsuCOTPmBzRQVbchNbuA2npvc=; b=ZD2uB6dHG1KFNJBlJCBzkEfUXa781EAXtaYCJkPiB1ifSWt4tJB+qz3Sr3vG5UpVwZ OdzKUjp4N0pG9HscfnQhQkSIme8R7gIQDW4k/5+aqXTBfo/T4h1YC+YQq2Q7XuhQG518 PBTOxQSCrsd8tpdXaX0PC72oJXyA0hYAWPFT+AClhL3/byzWC5iPsjkXcko3eLEiRJls j6xwpZzwrmP4fg+k6yV19+g57ku6JnP/m3gMFQkWY2JQnIsoltLBUyFoW8MKWuuk69WM PnKIdD+VagPoO4+Fa/c9uN68D/2DViRCkYMFp5+H7+Q2VZ5T4k2ex91mI9c6zM9pGqOS 4d8Q== X-Gm-Message-State: ALQs6tD4hgufhyX4KYzoFN5lSR89tlIg9ZKIPqyF3xHRosJFGZ7t33og k8QgXxTf4/ZoOaMRPSUuTiT0IvtYm84deSk2xiFsK9RxKZ8= X-Google-Smtp-Source: AIpwx48FVw7KvSoXB+jDYVBSI19KJai0AHNQLSQfu6ysIQDe0SgL9ymU3E4OVBH2GAIgjt7kkHLY1sL8fli+a8RSOQM= X-Received: by 10.223.174.214 with SMTP id y80mr2182521wrc.68.1523980371893; Tue, 17 Apr 2018 08:52:51 -0700 (PDT) MIME-Version: 1.0 From: "Paul Pluzhnikov via gdb-patches" Reply-To: Paul Pluzhnikov Date: Tue, 17 Apr 2018 15:53:00 -0000 Message-ID: Subject: [patch] Fix BZ 11420 -- configure uses incorrect link order when testing libpython To: gdb-patches ml Content-Type: multipart/mixed; boundary="001a113e6f8ab6f6dc056a0d5411" X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00338.txt.bz2 --001a113e6f8ab6f6dc056a0d5411 Content-Type: text/plain; charset="UTF-8" Content-length: 823 Greetings, https://stackoverflow.com/a/49868387 https://sourceware.org/bugzilla/show_bug.cgi?id=11420 Configure uses "gcc -o conftest -g ... conftest.c -ldl -lncurses -lm -ldl ... -lpthread ... -lpython2.7" when deciding whether give libpython is usable. That of course is the wrong link order, and only works for shared libraries (mostly by accident), and only on some systems. Attached patch fixes this. I am not sure about this part of the patch: - LIBS="$LIBS $new_LIBS" + LIBS="$new_LIBS $LIBS" I think it's always better to prepend new libraries. Thanks, 2018-04-17 Paul Pluzhnikov PR gdb/11420 * gdb/configure.ac: Prepend libpython. * gdb/python/python-config.py: Likewise. * gdb/configure: Regenerate. -- Paul Pluzhnikov --001a113e6f8ab6f6dc056a0d5411 Content-Type: text/plain; charset="US-ASCII"; name="gdb-bz11420-20180417.txt" Content-Disposition: attachment; filename="gdb-bz11420-20180417.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jg3uj70o0 Content-length: 3233 ZGlmZiAtLWdpdCBhL2dkYi9jb25maWd1cmUuYWMgYi9nZGIvY29uZmlndXJl LmFjCmluZGV4IDY5OGZjN2I4MzQuLmUxZjYzMGNkMzggMTAwNjQ0Ci0tLSBh L2dkYi9jb25maWd1cmUuYWMKKysrIGIvZ2RiL2NvbmZpZ3VyZS5hYwpAQCAt NzMyLDcgKzczMiw3IEBAIEFDX0RFRlVOKFtBQ19UUllfTElCUFlUSE9OXSwK ICAgc2F2ZV9DUFBGTEFHUz0kQ1BQRkxBR1MKICAgc2F2ZV9MSUJTPSRMSUJT CiAgIENQUEZMQUdTPSIkQ1BQRkxBR1MgJG5ld19DUFBGTEFHUyIKLSAgTElC Uz0iJExJQlMgJG5ld19MSUJTIgorICBMSUJTPSIkbmV3X0xJQlMgJExJQlMi CiAgIGZvdW5kX3VzYWJsZV9weXRob249bm8KICAgQUNfTElOS19JRkVMU0Uo QUNfTEFOR19QUk9HUkFNKFtbI2luY2x1ZGUgIlB5dGhvbi5oIl1dLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgW1tQeV9Jbml0aWFsaXpl ICgpO11dKSwKQEAgLTkyMiwxOSArOTIyLDE5IEBAIGVsc2UKICAgZWxpZiB0 ZXN0ICIke2hhdmVfcHl0aG9uX2NvbmZpZ30iICE9IGZhaWxlZDsgdGhlbgog ICAgIGlmIHRlc3QgIiR7aGF2ZV9saWJweXRob259IiA9IG5vOyB0aGVuCiAg ICAgICBBQ19UUllfTElCUFlUSE9OKHB5dGhvbjIuNywgaGF2ZV9saWJweXRo b24sCi0gICAgICAgICAgICAgICAgICAgICAgICR7cHl0aG9uX2luY2x1ZGVz fSwgIiR7cHl0aG9uX2xpYnN9IC1scHl0aG9uMi43IikKKyAgICAgICAgICAg ICAgICAgICAgICAgJHtweXRob25faW5jbHVkZXN9LCAiLWxweXRob24yLjcg JHtweXRob25fbGlic30iKQogICAgIGZpCiAgICAgaWYgdGVzdCAiJHtoYXZl X2xpYnB5dGhvbn0iID0gbm87IHRoZW4KICAgICAgIEFDX1RSWV9MSUJQWVRI T04ocHl0aG9uMi42LCBoYXZlX2xpYnB5dGhvbiwKLSAgICAgICAgICAgICAg ICAgICAgICAgJHtweXRob25faW5jbHVkZXN9LCAiJHtweXRob25fbGlic30g LWxweXRob24yLjYiKQorICAgICAgICAgICAgICAgICAgICAgICAke3B5dGhv bl9pbmNsdWRlc30sICItbHB5dGhvbjIuNiAke3B5dGhvbl9saWJzfSIpCiAg ICAgZmkKICAgICBpZiB0ZXN0ICR7aGF2ZV9saWJweXRob259ID0gbm87IHRo ZW4KICAgICAgIEFDX1RSWV9MSUJQWVRIT04ocHl0aG9uMi41LCBoYXZlX2xp YnB5dGhvbiwKLSAgICAgICAgICAgICAgICAgICAgICAgJHtweXRob25faW5j bHVkZXN9LCAiJHtweXRob25fbGlic30gLWxweXRob24yLjUiKQorICAgICAg ICAgICAgICAgICAgICAgICAke3B5dGhvbl9pbmNsdWRlc30sICItbHB5dGhv bjIuNSAke3B5dGhvbl9saWJzfSIpCiAgICAgZmkKICAgICBpZiB0ZXN0ICR7 aGF2ZV9saWJweXRob259ID0gbm87IHRoZW4KICAgICAgIEFDX1RSWV9MSUJQ WVRIT04ocHl0aG9uMi40LCBoYXZlX2xpYnB5dGhvbiwKLSAgICAgICAgICAg ICAgICAgICAgICAgJHtweXRob25faW5jbHVkZXN9LCAiJHtweXRob25fbGli c30gLWxweXRob24yLjQiKQorICAgICAgICAgICAgICAgICAgICAgICAke3B5 dGhvbl9pbmNsdWRlc30sICItbHB5dGhvbjIuNCAke3B5dGhvbl9saWJzfSIp CiAgICAgZmkKICAgZmkKICAgaWYgdGVzdCAiJHtoYXZlX2xpYnB5dGhvbn0i ID0gcHl0aG9uMi43IC1vICIke2hhdmVfbGlicHl0aG9ufSIgPSBweXRob24y NzsgdGhlbgpkaWZmIC0tZ2l0IGEvZ2RiL3B5dGhvbi9weXRob24tY29uZmln LnB5IGIvZ2RiL3B5dGhvbi9weXRob24tY29uZmlnLnB5CmluZGV4IGMyYjI5 NjljMzkuLjBkMzhlZDUwYzAgMTAwNjQ0Ci0tLSBhL2dkYi9weXRob24vcHl0 aG9uLWNvbmZpZy5weQorKysgYi9nZGIvcHl0aG9uL3B5dGhvbi1jb25maWcu cHkKQEAgLTU4LDEyICs1OCwxMSBAQCBmb3Igb3B0IGluIG9wdF9mbGFnczoK ICAgICAgICAgcHJpbnQgKHRvX3VuaXhfcGF0aCgnICcuam9pbihmbGFncykp KQogCiAgICAgZWxpZiBvcHQgaW4gKCctLWxpYnMnLCAnLS1sZGZsYWdzJyk6 Ci0gICAgICAgIGxpYnMgPSBbXQorICAgICAgICBsaWJzID0gWyctbHB5dGhv bicrcHl2ZXIgKyBhYmlmbGFnc10KICAgICAgICAgaWYgZ2V0dmFyKCdMSUJT JykgaXMgbm90IE5vbmU6CiAgICAgICAgICAgICBsaWJzLmV4dGVuZChnZXR2 YXIoJ0xJQlMnKS5zcGxpdCgpKQogICAgICAgICBpZiBnZXR2YXIoJ1NZU0xJ QlMnKSBpcyBub3QgTm9uZToKICAgICAgICAgICAgIGxpYnMuZXh0ZW5kKGdl dHZhcignU1lTTElCUycpLnNwbGl0KCkpCi0gICAgICAgIGxpYnMuYXBwZW5k KCctbHB5dGhvbicrcHl2ZXIgKyBhYmlmbGFncykKICAgICAgICAgIyBhZGQg dGhlIHByZWZpeC9saWIvcHl0aG9uWC5ZL2NvbmZpZyBkaXIsIGJ1dCBvbmx5 IGlmIHRoZXJlIGlzIG5vCiAgICAgICAgICMgc2hhcmVkIGxpYnJhcnkgaW4g cHJlZml4L2xpYi8uCiAgICAgICAgIGlmIG9wdCA9PSAnLS1sZGZsYWdzJzoK --001a113e6f8ab6f6dc056a0d5411--