From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87053-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9646 invoked by alias); 12 Jan 2012 23:27:21 -0000
Received: (qmail 9636 invoked by uid 22791); 12 Jan 2012 23:27:20 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_FRT_PROFILE2,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 23:27:01 +0000
Received: by wgbdt11 with SMTP id dt11so2377360wgb.12        for <gdb-patches@sourceware.org>; Thu, 12 Jan 2012 15:27:00 -0800 (PST)
Received: by 10.180.83.104 with SMTP id p8mr4418865wiy.4.1326410820492;        Thu, 12 Jan 2012 15:27:00 -0800 (PST)
Received: by 10.180.83.104 with SMTP id p8mr4418848wiy.4.1326410820372; Thu, 12 Jan 2012 15:27:00 -0800 (PST)
MIME-Version: 1.0
Received: by 10.223.144.142 with HTTP; Thu, 12 Jan 2012 15:26:29 -0800 (PST)
In-Reply-To: <CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com>
References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <CADPb22TZqh1KJv0KXxRNuhV8PZH-Z31CcggzJMBDJYo3OuZKdA@mail.gmail.com> <CALoOobMVWJB=u6Y8OMyNeva1KcgU7FP8FpR2aFQ4b2e+=QUgOQ@mail.gmail.com> <20120112212959.GA24491@host2.jankratochvil.net> <CALoOobOBfT4n5zXp-=4qyS_7+c0hkhWwxop9B=5aAHuti+bAWg@mail.gmail.com> <CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Thu, 12 Jan 2012 23:28:00 -0000
Message-ID: <CALoOobOOMBhUygng30y8L9MN5WqkXkEA-Y1zPsxghmgPHJguOA@mail.gmail.com>
Subject: Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
X-System-Of-Record: true
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00450.txt.bz2

On Thu, Jan 12, 2012 at 3:17 PM, Doug Evans <dje@google.com> wrote:

>> Wouldn't lstat need a configury #ifdef to make it build?
>
> [for reference sake, one patch in my basenames-may-differ series (not
> submitted) had a use for lstat.
> IWBN to have lstat in gdb so we could (appropriately of course) use it.

Right.

If there was an existing HAVE_LSTAT facility, I would definitely be for
using it here. But I am not sufficiently proficient with configury to add
it myself.

> OOC, Jan, what discussion led rise to having braces here:
>
> + =A0if (strcmp (dir1, dir2) =3D=3D 0)
> + =A0 =A0{
> + =A0 =A0 =A0/* Same directory, no point retrying. =A0*/
> + =A0 =A0 =A0goto cleanup;
> + =A0 =A0}
>
> and does that reasoning apply here:
>
> + =A0if (debuglink =3D=3D NULL)
> + =A0 =A0/* There's no separate debug info, hence there's no way we could
> + =A0 =A0 =A0 load it =3D> no warning. =A0*/
> + =A0 =A0return NULL;

I've added braces here (personally, I am all for braces ;-)


--=20
Paul Pluzhnikov