From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id C02383858439 for ; Wed, 21 Feb 2024 21:21:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C02383858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C02383858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708550509; cv=none; b=sd+xbmxftIrKcXIxrUsc61kbjQDqFWxllgtREJJARX4bA91W1u/zfcgQ2sW/E6PtukjSW9UsnHOInqRmcrdxg0LkgdmGJxzUlPoCIX74JRzIJJn04q7HnPzletPR5ITPBCo8jhLcJQvyQE3SLicxlpYdfbT0htilEtrk+oAUWIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708550509; c=relaxed/simple; bh=90TPjpcczcknfhgW0h1lb4xRAWEsVdrzMXOvqasQLC0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xa5IaEXaUj8wMbdQNt4SiKUVfw7sTk910Igg+xcKrIrCIYjrAixOvBg39DRA3wKfUPW5Fxl/RuJMC7pgOrmB0SyatMVEQRdoYea0r19PMCexSEPEqhqLtDaaTHnj6Xdn9zdDyWPIKSGqjw1tIJhTjQYQmQ+lPuKv3NPbSl5wAYc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-299354e5f01so165549a91.1 for ; Wed, 21 Feb 2024 13:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708550505; x=1709155305; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N+EuM4qdRmv4XVB/emDtFz/pK3i1xvQ+mTtpsaxFtPk=; b=OfDYOCRgxEzqUTjTAfqyuZZxHC/w7ugF3MkmmFBnBhAq75WrP/EmdI+Yxpp7MLNMeT ksQEI4bgrdcSn9tr5ndD54CER2YxMBC94b6XKn1XhZ/+LLgtcvbs5kCwztgGhpg2blFP Acst9Ps9XEC2Yn9ZdfXOT1+9EfPvfhJGORMiIQOBL5ENtZcoyeN9KvHQwtJwkQ89QeiE dvG2kjB7OSCQ3gLmsH4wJ6v2W5uc+FVCSqRR6IKjp13DCfr8dNJkFh2owfpfsxf019Ox 0OJcR0wwmcHGfXwCtdr3dRyIYp1hCTz91qAuDWreHRiOM1yqIx3XiMu1WPdSOyX6qWZg ulHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708550505; x=1709155305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+EuM4qdRmv4XVB/emDtFz/pK3i1xvQ+mTtpsaxFtPk=; b=HVKMaZAcNPZjseh4x0GE+U9tMp+g5KcFCqCefG1xSffVx661QhyaMwnH1eNkobK0ED DV5TSK9sHW9GTsjoTo1bZX2zaxPze3NfTGc7pGRhKgHzRc3mhM9PvOMYBRKqNIx77WEj rBErFtM3sMFl7bjyTosuQNl9H8uOg/wWM305BQQKsk3iV2jEdmssqHl//IO3mG7aB1wZ MAFIZOiUXSSqDL0aHem1tMglg3RkijbY7er7evVHid2db1NseZTLopPjoce5weAOfkxV 7g8iyjY85clGOtuBAYEt9fZF3Sg8gECVE/cpDS0SGRSmwTGfrXwvVnJuRT2X7bey2JeG xDPQ== X-Gm-Message-State: AOJu0YwXGJqtv9I+p68ezJAhj/NPcVHvPMQFftK6WudpO8A0+4om+XsJ Xaqn6RepK7w+lH2jMmmb7/Aa05wUgq7Fuvj4SHHinqCaChdxqxliO5W5iUe/ZT1IB9rhURpSP1j yfD5NdaGytv6W0r7Z5A8jJ2DVPdwyHJky X-Google-Smtp-Source: AGHT+IHpOwXeA2rMBA55mjyZTwwnMs3aa/qlFBWkbpvqreBOit537zCsyPUdDMsd2C7nqgRdRayb3x0C77C6Fps0qs8= X-Received: by 2002:a17:90b:124c:b0:299:3469:832 with SMTP id gx12-20020a17090b124c00b0029934690832mr940269pjb.1.1708550504533; Wed, 21 Feb 2024 13:21:44 -0800 (PST) MIME-Version: 1.0 References: <20240214154012.32319-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 21 Feb 2024 13:21:08 -0800 Message-ID: Subject: Re: [PATCH v2] gdb: Add XMM16-XMM31 and K0-K1 DWARF register number mapping To: "Willgerodt, Felix" Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3020.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 21, 2024 at 12:33=E2=80=AFAM Willgerodt, Felix wrote: > > > -----Original Message----- > > From: H.J. Lu > > Sent: Mittwoch, 14. Februar 2024 16:40 > > To: gdb-patches@sourceware.org > > Cc: Willgerodt, Felix > > Subject: [PATCH v2] gdb: Add XMM16-XMM31 and K0-K1 DWARF register numbe= r > > mapping > > > > Changes in v2: > > > > 1. Remove UTF-8 encoding. > > > > --- > > Add XMM16-XMM31 and K0-K1 DWARF register number mapping to > > amd64_dwarf_regmap. > > --- > > gdb/amd64-tdep.c | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c > > index a8ff9246b8a..b6ff1c67a86 100644 > > --- a/gdb/amd64-tdep.c > > +++ b/gdb/amd64-tdep.c > > @@ -235,7 +235,28 @@ static int amd64_dwarf_regmap[] =3D > > /* Floating Point Control Registers. */ > > AMD64_MXCSR_REGNUM, > > AMD64_FCTRL_REGNUM, > > - AMD64_FSTAT_REGNUM > > + AMD64_FSTAT_REGNUM, > > + > > + /* XMM16-XMM31. */ > > + AMD64_XMM16_REGNUM + 0, AMD64_XMM16_REGNUM + 1, > > + AMD64_XMM16_REGNUM + 2, AMD64_XMM16_REGNUM + 3, > > + AMD64_XMM16_REGNUM + 4, AMD64_XMM16_REGNUM + 5, > > + AMD64_XMM16_REGNUM + 6, AMD64_XMM16_REGNUM + 7, > > + AMD64_XMM16_REGNUM + 8, AMD64_XMM16_REGNUM + 9, > > + AMD64_XMM16_REGNUM + 10, AMD64_XMM16_REGNUM + 11, > > + AMD64_XMM16_REGNUM + 12, AMD64_XMM16_REGNUM + 13, > > + AMD64_XMM16_REGNUM + 14, AMD64_XMM16_REGNUM + 15, > > + > > + /* Reserved. */ > > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, > > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, > > + -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, > > + > > + /* Mask Registers. */ > > + AMD64_K0_REGNUM + 0, AMD64_K0_REGNUM + 1, > > + AMD64_K0_REGNUM + 2, AMD64_K0_REGNUM + 3, > > + AMD64_K0_REGNUM + 4, AMD64_K0_REGNUM + 5, > > + AMD64_K0_REGNUM + 6, AMD64_K0_REGNUM + 7 > > }; > > > > static const int amd64_dwarf_regmap_len =3D > > -- > > 2.43.0 > > > While I can't approve, this looks good to me. > > Reviewed-By: Felix Willgerodt > Who can approve this patch? Thanks. --=20 H.J.