From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by sourceware.org (Postfix) with ESMTPS id 6DB493858D1E for ; Wed, 20 Mar 2024 10:48:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DB493858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DB493858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710931732; cv=none; b=VgJT6LwLX7Etlww8SiVr75RaNmUm/Sl69TtpY7X8h2o4R9j7V/XQHEav0sA3WzrSPOzgU0N3ldiuymA+fYearrsPTX/lBWvQpQCMu71eAty3nIBqqSkqx2Qx696iNI0oZxbWiWv/ruW9F9P08TPLzZ4AyyGxZKC2lBGs43fUKhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710931732; c=relaxed/simple; bh=6sA4xLHPxLN7qfIlYqwHLa72f7uxWBAKhFRWo2jJxZA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OXt1cvRestxRI5dY8kFPeVbb9fiVcRhmtS6MJDFZd5Gl91iE8sfPM/yLmAt2O+x2E+h/OfIA5kToOlzp7n+/iIFC7WU6/Hb0xn6PtwJnhp6neJl5ucfS3zJoTp1TqENKC8GJlTe5dj2EmL9ott10u2d+1q2CInDMdm69hENzZqw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-60a0599f631so59277867b3.2 for ; Wed, 20 Mar 2024 03:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710931730; x=1711536530; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Je5gy8yqXJ5pue1BnlND0orGiJH0gxheSpK38VxUsuY=; b=LDwUOfn6wEcmpu1JjKOpSuUHkTOAkqwRoyZYet4OfLVLEcSSPQzUfmB0gJQklU5brL 90Sge0YLRWkHQZhyN4c96AVOXmiHAhMywesR/SzhNwH8AKFTLYl4bG9FR4c/4MGpre9M l517EgmXXWL9nFK4vDWA2F4WDgFZU2Wqoxe2QqxEOnBfUBNqtd0gIUxKyRiJ8kBW4hUX mFS47o4ZWKdFhbA2QF3KjeGkx/FZhlqWOM0qQyWUtiABOiho1Ai6EPxG75TB3bNAvKFl eGsE1khBxewofUfbjeuarHF+QpQ2EWSGnxPa4apoV76wdiNlrHmM7fEefAOl1NXnGWx7 qIgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710931730; x=1711536530; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Je5gy8yqXJ5pue1BnlND0orGiJH0gxheSpK38VxUsuY=; b=s9HxfGaXaYY0Sh7G3+en7Dq/0JMiLsQOdnceyi8xxiSYVDQLvuBMl9Zee8kDzUJBi2 CD6MqOj0ncOD7UHd3860ZjyZMXSm/vT1XEX+7yGmTvcAapC2A+ZwsTTmCrqieE+xHr3p 6jJIAadisbJaIIsanoK9NrdJuVQ8hsAestPRhmx6dVWq5mOsFXPV7e+lQ4ub8W9GhdzA T8oLIoTywVdJX4el8nQMCPrGg9/FtFSCbUqO//0nAwAAT59WCR3d1/WQ5LPz8TGLq+0G IkE6bsuCCOuLMZByGnJkezgb9GLo9bhehlSGP+ZLCiIhlh9rY4DqFVyGAHlHeY5fNSev ND5A== X-Gm-Message-State: AOJu0YyHVbMnBr0k2XwkpHOWGk7ETfgDNi0+F3E+Ygq7pH6rax32Zkvk rAuUqEa342cLfI7sxHJ8K+gKyQBFitRmgEBL9EMWH3OHMFl43LkE2Hfq4jU3n/utgCLJCzEkgKb R0UnvAO6/7AOZ2wNwJyFV1i1RQ24= X-Google-Smtp-Source: AGHT+IHwzpiK4x7fvp1dvnozgbo+f2dE2rlPNWNS69B1l6UG4ca6xUufRqntxXsnaw/KJ3orArtnZXoirVUyBVFECGk= X-Received: by 2002:a0d:f485:0:b0:610:e457:a7a7 with SMTP id d127-20020a0df485000000b00610e457a7a7mr3928180ywf.14.1710931729792; Wed, 20 Mar 2024 03:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20240319152558.45742-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 20 Mar 2024 03:48:13 -0700 Message-ID: Subject: Re: [PATCH] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 To: "Willgerodt, Felix" Cc: GDB , John Baldwin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 20, 2024 at 1:40=E2=80=AFAM Willgerodt, Felix wrote: > > > -----Original Message----- > > From: H.J. Lu > > Sent: Dienstag, 19. M=C3=A4rz 2024 19:36 > > To: GDB ; John Baldwin ; > > Willgerodt, Felix > > Subject: [PATCH] gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 > > > > Since MPX isn't available for x32, we should clear X86_XSTATE_MPX bits > > on x32. > > > > PR server/31511 > > * linux-x86-low.cc (x86_linux_read_description): Clear > > X86_XSTATE_MPX bits in xcr0 on x32. > > --- > > gdbserver/linux-x86-low.cc | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc > > index 3af0a009052..28b5d523b8e 100644 > > --- a/gdbserver/linux-x86-low.cc > > +++ b/gdbserver/linux-x86-low.cc > > @@ -938,6 +938,10 @@ x86_linux_read_description (void) > > xcr0 =3D xstateregs[(I386_LINUX_XSAVE_XCR0_OFFSET > > / sizeof (uint64_t))]; > > > > + /* No MPX on x32. */ > > + if (!is_elf64) > > + xcr0 &=3D ~X86_XSTATE_MPX; > > + > > Doesn't that also disable it for 32-bit? Fixed in the v2 patch with + /* No MPX on x32. */ + if (machine =3D=3D EM_X86_64 && !is_elf64) + xcr0 &=3D ~X86_XSTATE_MPX; + > x86_target::low_siginfo_fixup() uses this to check x32: > > /* No fixup for native x32 GDB. */ > else if (!is_elf64 && sizeof (void *) =3D=3D 8) > > Thanks. --=20 H.J.