From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
GDB <gdb-patches@sourceware.org>
Subject: Re: [commit 7.8] [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642)
Date: Mon, 15 Dec 2014 20:02:00 -0000 [thread overview]
Message-ID: <CAMe9rOqefYPoN-qGpH-z2kiHpyB5q7_52YA1ibTTAGX4qeF2Qg@mail.gmail.com> (raw)
In-Reply-To: <20141215193658.GC5457@adacore.com>
On Mon, Dec 15, 2014 at 11:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I'd like to backport
>>
>> https://sourceware.org/ml/gdb-patches/2014-12/msg00116.html
>>
>> to 7.8 branch.
>
> This is a fairly big patch...
> 1. How bad is performance without it?
It was very bad, like > 100x slower.
> 2. Can you find a binutils maintainer that will vouch that
> this patch is 100% safe?
As the x86 binutils maintainer, do I count?
> The 7.8.2 is in the pipe because we found a number of crippling issues
> in 7.8.1. At this point, we should only consider extra-safe patches,
> or patches that fix issues considered to be blocking the use of 7.8.1.
> For yours to qualify, you'll need to answer both questions above.
>
> --
> Joel
--
H.J.
next prev parent reply other threads:[~2014-12-15 20:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 19:54 Jan Kratochvil
2014-12-13 14:23 ` Joel Brobecker
2014-12-13 14:39 ` [commit] " Jan Kratochvil
2014-12-13 18:18 ` Doug Evans
2014-12-15 15:06 ` Joel Brobecker
2014-12-15 15:21 ` Jan Kratochvil
2014-12-15 19:12 ` [commit 7.8] " Jan Kratochvil
2014-12-15 19:23 ` H.J. Lu
2014-12-15 19:37 ` Joel Brobecker
2014-12-15 20:02 ` H.J. Lu [this message]
2014-12-15 20:41 ` Joel Brobecker
2014-12-15 21:09 ` H.J. Lu
2014-12-15 22:11 ` H.J. Lu
2014-12-15 22:44 ` Joel Brobecker
2014-12-15 22:53 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqefYPoN-qGpH-z2kiHpyB5q7_52YA1ibTTAGX4qeF2Qg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).