From: Max Filippov <jcmvbkbc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Maxim Grigoriev <maxim2405@gmail.com>,
Woody LaRue <larue@cadence.com>,
Marc Gauthier <marc@cadence.com>
Subject: Re: [PATCH v2] gdb: xtensa: fix frame initialization when PC is invalid
Date: Tue, 29 Mar 2016 19:56:00 -0000 [thread overview]
Message-ID: <CAMo8BfKiyKkqZ01PpLjWoLN9QXcfWWaF69+c7qozOaAEr8D39A@mail.gmail.com> (raw)
In-Reply-To: <56FAD2EA.50003@redhat.com>
On Tue, Mar 29, 2016 at 10:09 PM, Pedro Alves <palves@redhat.com> wrote:
> On 03/29/2016 07:17 PM, Max Filippov wrote:
>> - op1 = read_memory_integer (pc, 1, byte_order);
>> - if (XTENSA_IS_ENTRY (gdbarch, op1))
>> + if (safe_read_memory_integer (pc, 1, byte_order, &op1)
>> + && XTENSA_IS_ENTRY (gdbarch, op1))
>> {
>
> I'm surprised if this compiles without an "incompatible pointer type"
> warning/error? safe_read_memory_integer's last parameter is
> 'LONGEST *', while op1 is 'char', AFAICS. So you need to change op1
> to be a LONGEST to match.
You're right, sorry. I've checked that it builds and works, but I've missed
that it was configured with --disable-werror.
--
Thanks.
-- Max
prev parent reply other threads:[~2016-03-29 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 18:18 Max Filippov
2016-03-29 19:09 ` Pedro Alves
2016-03-29 19:56 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfKiyKkqZ01PpLjWoLN9QXcfWWaF69+c7qozOaAEr8D39A@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=larue@cadence.com \
--cc=marc@cadence.com \
--cc=maxim2405@gmail.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).