From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id C17E8384AB58 for ; Fri, 3 May 2024 17:17:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C17E8384AB58 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C17E8384AB58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714756629; cv=none; b=JlWlIWjnb72EsGknWR3QNU0nQ+ND5segxb0lUUKL6HCbkB1v6n60pSA7qg3T4+vo+Hj7cr4R+E+Kl0YXHbfnU9YO3Qgae/6EV7QsM7sQRdpH2ig+qJAFnSRhgGc2trulByNVrtqtn0v6RkrBSCdzeYazKezKxm8d95/STZr3y7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714756629; c=relaxed/simple; bh=5ayB2rJnjxH1ZagdWB70qnAvWvCESNtsoFSXcSBqVP8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=PPjy7YTHb0Iusfqel9YRW/D7HAjgWblJI47ES0IUvRlmLI4NcSRuG8rV5YnLH4gbz8iY592W1jd9d6TfEaOqPx3yCd6wXUFADREcYkmb06S/lN1EtXEPgcYbhSyTtiMdWYIssMgnvVNPmOYX1HygbpsHhC4HNhIWm9dw+vl+W8c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-41bab13ca80so55332505e9.0 for ; Fri, 03 May 2024 10:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714756623; x=1715361423; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5EmWE/9iIwSEJnmSG/8OMWyMxP2P4IALEWHmkFBNXZA=; b=LLV1uk3A5tohCCkMzkgmxoG8kn1Wb8SI218kkZUXJ2a+YqWr5MrUINtRvo7qQBcG62 m9S1AywcXUWk66cioVXniTIJ16fKsqtvQ86irwNlPx/EsoOJJax4ca+DN2Gja9wboKxl w2+EtRsNFLOFDXnej9/0GL8k9teB6a4jL3Ic7xHVmx6BejE+PeCm3/+lmQWek7siFpTp vPRS6hsAdZTf0U6swREkvAKshqqYtdveslHhjdWRBXRjTGVnyqvoF+/zdVKNTjZsalfo XVj46gXxRj/j6AC3T+CEK2SXp8an7YRLh+ty4dp/JPGJYjTm6IK5r8/4DegA2LqmyF5D +G3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714756623; x=1715361423; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5EmWE/9iIwSEJnmSG/8OMWyMxP2P4IALEWHmkFBNXZA=; b=roSoZlvwsO0wLgb1iKeKyOb8qVQQHcRYDlxqvJfVf1/Lv8Nr6BNfRIEBXipY1e+jAi eonbMHVZWtHQfC4G2PrDVzPzlTrPB4zisM0grJYDPZaafJhML7XXMM4nRwDRNba9SZZT SjZ852gP9UlRXFAlX4f1ZNPCQGXkdhh62LmRqQZtQMgy8KkmNdq1Cv7MAY+JCuSpaIFS ebKOcjekSzhtTYD72Pt6M1BqRn1mjdWNj/6JE3eiOYcGyzbx7pQH3r94opV6i58ZxNMk raW5wVjdyYxQu+JKsN/HycWlXLeHNDwA9Eg0aQdIOJfpiAY/5LVE0Q7pXUypWOuhq6Xl Oveg== X-Gm-Message-State: AOJu0YwAWKKfP6N2mTMvCfuvIzFMhmSMvh1U33i7cIddzc0msgiYutUm /6yGaBmhBkLdB/6I0sWhHxVhjsFRB2O1lNqiRSXf9Pko6js7LFi8AY4ddzd4C92HockkXvGleMD BaLhBONuYOb4q+SAJCoBVQ+H1JyKyOutl X-Google-Smtp-Source: AGHT+IGIAmyigOa72qthfSelgkKiL9tp0rX5EWCckyJHkJmJUTWejb7ilTC+NNg7jDdlKDwI/QxaJwLs+qjYft/hUnc= X-Received: by 2002:a05:600c:350a:b0:419:e773:9052 with SMTP id h10-20020a05600c350a00b00419e7739052mr2581988wmq.14.1714756622914; Fri, 03 May 2024 10:17:02 -0700 (PDT) MIME-Version: 1.0 References: <20240414193653.3289837-1-achronop@gmail.com> <72c908ba-26c4-48c1-bedb-b75aad0c3733@palves.net> In-Reply-To: <72c908ba-26c4-48c1-bedb-b75aad0c3733@palves.net> From: Alex Chronopoulos Date: Fri, 3 May 2024 20:16:50 +0300 Message-ID: Subject: Re: [PATCH v3] Change message when reaching end of reverse history. To: gdb-patches@sourceware.org Cc: Pedro Alves , "Metzger, Markus T" , Guinevere Larsen Content-Type: multipart/alternative; boundary="000000000000629eab06178fe361" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000629eab06178fe361 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you, Pedro. No worries, it's still early enough :) I like your suggestions and would happily follow them. I believe they are clear and leave fewer questions for the user. I also prefer the extended version for the backward case. However, I don't want to make the final call. I'll wait for others to comment, and I'll update the patch when we have the final version. On Tue, Apr 23, 2024 at 10:36=E2=80=AFPM Pedro Alves wro= te: > Sorry for not chiming in earlier... > > On 2024-04-14 20:36, Alex Chronopoulos wrote: > > In a record session, when we move backward, GDB switches from normal > > execution to simulation. Moving forward again, the emulation continues > > until the end of the reverse history. When the end is reached, the > > execution stops, and a warning message is shown. This message has been > > modified to indicate that the forward emulation has reached the end, but > > the execution can continue as normal, and the recording will also > continue. > > > > Before this patch, the warning message shown in that case was the same = as > > in the reverse case. This meant that when the end of history was reached > in > > either backward or forward emulation, the same message was displayed: > > > > "No more reverse-execution history." > > > > This message remains for backward emulation. However, in forward > emulation, > > it has been modified to: > > > > "End of recorded history; following steps will be added to history." > > > > IMO, "steps" here is confusing. It's ambiguous with stepping. Like as if > you're saying that the following "step" commands will be added to history. > "But what about if I continue??" > > It also isn't true that "following steps will be added to history.". If > the user does "reverse-continue" for example, they won't, they're > already there... > > The following tweak would be more accurate and not have that "step" > confusion, IMO: > > "End of recorded history; following forward execution will be added to > history." > > and it's still under 80 chars. > > Except it fells a bit awkward, for not stating that we're stopping before > talking about following execution. This would be clearer to me: > > Reached end of recorded history; stopping. > Following forward execution will be added to history. > > > Also, with the patch, we have these two messages, for the forward case: > > End of recorded history; following steps will be added to history. > > and for the reverse case: > > No more reverse-execution history. > > I read the v1/v2 discussions, and I have to say that I don't understand h= ow > the potential user confusion that led to changing the "No more > reverse-execution" > wording in the forward case doesn't apply to the reverse case... I think > we should be consistent. > > With my suggestion above, we could have: > > forward: > > Reached end of recorded history; stopping. > Following forward execution will be added to history. > > backward: > > Reached end of recorded history; stopping. > > or, backward: > > Reached end of recorded history; stopping. > Backward execution from here not possible. > > --000000000000629eab06178fe361--