From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29761 invoked by alias); 7 Jul 2014 09:32:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29709 invoked by uid 89); 7 Jul 2014 09:32:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 09:32:44 +0000 Received: by mail-oa0-f48.google.com with SMTP id m1so4255439oag.21 for ; Mon, 07 Jul 2014 02:32:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=boLUG9UgZQP/wFi7TtWnujEmfWtyFBX4ybbo93pJhBs=; b=M70UcavJ3l/pZKoT2rHCE2GmT3iZIFTjm7yvf2PQk4qgXxAXXXi3iisaEAICjnazZp b23FoVo8DhFSTCfXoGM0BZQJAopZcK576EZfHqW0vNUESHEAVXwMBcx+V0Qrfl0WbtEF YT5JazcFAt8Gusdo1IgTvypLTnwZ6GDDotnMSJEsUdW3lx8VAs2P9jwdfsEi4FV0TblD Ovixt9aUpiTyDuqUv4j6tXVluKynEZ2E+EEu/Ezq5wXrgZAyDCQpiZ6mgc60w+X15JVf Fl+ddOHzTY+40WcD2/a54shB4qNI/pXtruzv+O45wEJYfZslIHxh2vFHu4O1R/Uf1Fc6 0XLw== X-Gm-Message-State: ALoCoQnbD7myE9WCFNX6/fDnhoWIfN1P22HwCLT/n3g85kdDrToFzsqIUtMFQ3v28IhhKiMr6BTC X-Received: by 10.182.106.99 with SMTP id gt3mr30050319obb.24.1404725561764; Mon, 07 Jul 2014 02:32:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.22.11 with HTTP; Mon, 7 Jul 2014 02:32:21 -0700 (PDT) In-Reply-To: <1403714949-28133-3-git-send-email-arnez@linux.vnet.ibm.com> References: <1403714949-28133-1-git-send-email-arnez@linux.vnet.ibm.com> <1403714949-28133-3-git-send-email-arnez@linux.vnet.ibm.com> From: Omair Javaid Date: Mon, 07 Jul 2014 09:32:00 -0000 Message-ID: Subject: Re: [PATCH v2 02/13] regcache: Add functions suitable for regset_supply/collect. To: Andreas Arnez Cc: "gdb-patches@sourceware.org" , Yao Qi , Mark Kettenis Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00107.txt.bz2 On 25 June 2014 21:48, Andreas Arnez wrote: > These functions are intended to suit all targets that don't require too > special logic in their regset supply/collect methods. Having such > generic functions helps reducing target-specific complexity. > > gdb/ > * regcache.c: Include "regset.h". > (regcache_supply_regset, regcache_collect_regset): New functions. > * regcache.h (struct regcache_map_entry): New structure. > (REGCACHE_MAP_SKIP_BYTES): New enum value. > (regcache_supply_regset, regcache_collect_regset): New prototypes. > --- > gdb/regcache.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > gdb/regcache.h | 44 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 110 insertions(+) > > diff --git a/gdb/regcache.c b/gdb/regcache.c > index 5ee90b0..78fd962 100644 > --- a/gdb/regcache.c > +++ b/gdb/regcache.c > @@ -30,6 +30,7 @@ > #include "exceptions.h" > #include "remote.h" > #include "valprint.h" > +#include "regset.h" > > /* > * DATA STRUCTURE > @@ -1068,6 +1069,71 @@ regcache_raw_collect (const struct regcache *regcache, int regnum, void *buf) > memcpy (buf, regbuf, size); > } > > +/* Supply register REGNUM from BUF to REGCACHE, using the register map > + in REGSET. If REGNUM is -1, do this for all registers in > + REGSET. */ > + > +void > +regcache_supply_regset (const struct regset *regset, > + struct regcache *regcache, > + int regnum, const void *buf, size_t size) > +{ > + const struct regcache_map_entry *map = regset->regmap; > + int offs = 0; > + int i, count; > + > + for (i = 0; (count = map[i].count) != 0; i++) > + { > + int regno = map[i].regno; > + > + if (regno == REGCACHE_MAP_SKIP_BYTES) > + offs += count; > + else > + for (; count--; regno++) > + { > + int new_offs = offs + regcache->descr->sizeof_register[regno]; > + > + if (new_offs <= size && (regnum == -1 || regnum == regno)) > + regcache_raw_supply (regcache, regno, > + buf ? (const gdb_byte *) buf + offs > + : NULL); > + offs = new_offs; > + } > + } > +} > + > +/* Collect register REGNUM from REGCACHE to BUF, using the register > + map in REGSET. If REGNUM is -1, do this for all registers in > + REGSET. */ > + > +void > +regcache_collect_regset (const struct regset *regset, > + const struct regcache *regcache, > + int regnum, void *buf, size_t size) > +{ > + const struct regcache_map_entry *map = regset->regmap; > + int offs = 0; > + int i, count; > + > + for (i = 0; (count = map[i].count) != 0; i++) > + { > + int regno = map[i].regno; > + > + if (regno == REGCACHE_MAP_SKIP_BYTES) > + offs += count; > + else > + for (; count--; regno++) > + { > + int new_offs = offs + regcache->descr->sizeof_register[regno]; > + > + if (new_offs <= size && (regnum == -1 || regnum == regno)) > + regcache_raw_collect (regcache, regno, > + (gdb_byte *) buf + offs); > + offs = new_offs; > + } > + } > +} > + > > /* Special handling for register PC. */ > > diff --git a/gdb/regcache.h b/gdb/regcache.h > index 8423f57..73ee043 100644 > --- a/gdb/regcache.h > +++ b/gdb/regcache.h > @@ -147,6 +147,50 @@ extern void regcache_raw_supply (struct regcache *regcache, > extern void regcache_raw_collect (const struct regcache *regcache, > int regnum, void *buf); > > +/* Mapping between register numbers and offsets in a buffer, for use > + in the '*regset' functions below. In an array of > + 'regcache_map_entry' each element is interpreted like follows: > + > + - If 'regno' is a register number: Map register 'regno' to the > + current offset (starting with 0) and increase the current offset > + by the register's size. Repeat this with consecutive register > + numbers up to 'regno+count-1'. > + > + - If 'regno' is REGCACHE_MAP_SKIP_BYTES: Add 'count' to the current > + offset. > + > + - If count=0: End of the map. */ > + > +struct regcache_map_entry > +{ > + int count; > + int regno; > +}; > + > +/* Special value for the 'regno' field in the struct above. */ > + > +enum > + { > + REGCACHE_MAP_SKIP_BYTES = -1, > + }; > + > +/* Transfer a set of registers (as described by REGSET) between > + REGCACHE and BUF. If REGNUM == -1, transfer all registers > + belonging to the regset, otherwise just the register numbered > + REGNUM. The REGSET's 'regmap' field must point to an array of > + 'struct regcache_map_entry'. > + > + These functions are suitable for the 'regset_supply' and > + 'regset_collect' fields in a regset structure. */ > + > +extern void regcache_supply_regset (const struct regset *regset, > + struct regcache *regcache, > + int regnum, const void *buf, > + size_t size); > +extern void regcache_collect_regset (const struct regset *regset, > + const struct regcache *regcache, > + int regnum, void *buf, size_t size); > + > > /* The type of a register. This function is slightly more efficient > then its gdbarch vector counterpart since it returns a precomputed > -- > 1.8.4.2 > Is there a way around avoiding the loop in supply/collect where regnum != -1? It should be more efficient in cases where we are looking for a register with regnum > 0.