Re: [PATCH 2/7] Fixes for aarch64-linux core file support

[Omair Javaid <omair.javaid@linaro.org>]

On 21 October 2014 18:24, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>    /* Enable longjmp.  */
>>    tdep->jb_pc = 11;
>>
>> +  /* Install supported register note sections.  */
>> +  set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
>> +
>>    set_gdbarch_regset_from_core_section (gdbarch,
>>                                       aarch64_linux_regset_from_core_section);
>
> Is this patch stale?  I don't see the definition of
> set_gdbarch_core_regset_sections.  On the other hand, I see
> aarch64-linux-tdep.c already has:
>
> /* Implement the "regset_from_core_section" gdbarch method.  */
>
> static void
> aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
>                                             iterate_over_regset_sections_cb *cb,
>                                             void *cb_data,
>                                             const struct regcache *regcache)
> {
>   cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset,
>       NULL, cb_data);
>   cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset,
>       NULL, cb_data);
> }
>
> ...
>   set_gdbarch_iterate_over_regset_sections
>     (gdbarch, aarch64_linux_iterate_over_regset_sections);
>
> I assume this patch is no longer needed.

Agreed!

>
> --
> Yao (齐尧)