From: Omair Javaid <omair.javaid@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
Pedro Alves <palves@redhat.com>,
"Metzger, Markus T" <markus.t.metzger@intel.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [PR gdb/23127] [AArch64] Fix tagged pointer support
Date: Fri, 25 May 2018 17:28:00 -0000 [thread overview]
Message-ID: <CANW4E-0vXiO8bCW+v_3hxhQUjDdMoFdPsj6xtF1JbwAK8+ifog@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOr8KT23FJ5p+jp0iW6Bszuekv7y+Dmz8G57n58-ohA2ow@mail.gmail.com>
On Fri, 25 May 2018, 10:12 PM H.J. Lu, <hjl.tools@gmail.com> wrote:
> On Fri, May 25, 2018 at 10:11 AM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
> > On Friday, May 25 2018, I wrote:
> >
> >> On Monday, May 21 2018, Omair Javaid wrote:
> >>
> >>> On Mon, 21 May 2018, 9:06 PM H.J. Lu, <hjl.tools@gmail.com> wrote:
> >>>
> >>>> On Wed, May 9, 2018 at 7:19 AM, Pedro Alves <palves@redhat.com>
> wrote:
> >>>> > Hello,
> >>>> >
> >>>> > Thanks much for all the investigation & discussion, both of you.
> >>>> >
> >>>> > On 05/08/2018 10:31 AM, Omair Javaid wrote:
> >>>> >
> >>>> >> I was wondering if you can kindly help review this patch.
> >>>> >> This is a critical bug as it blocks kernel debugging on AArch64.
> >>>> >> Also can we push this to GDB 8.1.1 once it gets accepted?
> >>>> >
> >>>> > Yes, this is OK for both master and branch.
> >>>> >
> >>>> > Please add "PR gdb/23127" to the ChangeLog before pushing.
> >>>> >
> >>>>
> >>>> This breaks gdb on x86-64:
> >>>>
> >>>> https://sourceware.org/bugzilla/show_bug.cgi?id=23210
> >>>>
> >>>>
> >>>>
> >>> Hmm. I ll check it out. Thanks for reporting.
> >>
> >> Hi Omair,
> >>
> >> Any news on this failure? It is causing the testcase to take more than
> >> 14 hours to run when using --target_board=unix/-m32, and is impacting
> >> some of our builders on BuildBot.
> >
> > Apparently you sent a fix already. Sorry about this message.
> >
>
> But the fix is wrong.
>
I will update gdbarch as suggested. Are there any other issues in the fix I
should address.?
>
> --
> H.J.
>
next prev parent reply other threads:[~2018-05-25 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 1:32 Omair Javaid
2018-05-01 15:02 ` Daniel Thompson
2018-05-08 9:32 ` Omair Javaid
2018-05-09 14:19 ` Pedro Alves
2018-05-09 15:13 ` Joel Brobecker
2018-05-21 16:16 ` H.J. Lu
2018-05-21 16:27 ` Omair Javaid
2018-05-21 17:37 ` H.J. Lu
2018-05-25 17:11 ` Sergio Durigan Junior
2018-05-25 17:15 ` Sergio Durigan Junior
2018-05-25 17:18 ` H.J. Lu
2018-05-25 17:28 ` Omair Javaid [this message]
2018-05-25 18:41 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANW4E-0vXiO8bCW+v_3hxhQUjDdMoFdPsj6xtF1JbwAK8+ifog@mail.gmail.com \
--to=omair.javaid@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).