From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51211 invoked by alias); 26 Jan 2018 22:31:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51083 invoked by uid 89); 26 Jan 2018 22:31:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:alternative, H*RU:209.85.216.196, Hx-spam-relays-external:209.85.216.196, receipt X-HELO: mail-qt0-f196.google.com Received: from mail-qt0-f196.google.com (HELO mail-qt0-f196.google.com) (209.85.216.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jan 2018 22:31:43 +0000 Received: by mail-qt0-f196.google.com with SMTP id f4so5110778qtj.6 for ; Fri, 26 Jan 2018 14:31:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GD+v7q9BMP4E26yBsDzdO/xiPMMMQWGl7k49A1XbvEM=; b=CHRAe6ptoh99cP7+rAsuT+DTCERbSo1OdkzSQxtLaDeZJVIxqFJSI1l0dFqRTFwcyY ckzxOTFK53kR9kgzBMZB5QlQOnytE9NJkPYXPAStPzcIggVNgaC4CXYg0d3Q4ICaj7T2 OAyjMgD+MMeGFIxW+ejbgBDu4YYMuF6hXTJ2dm41PyUVJuCMPnt9yuOvbpGTbw+hxmCQ enpT5M5f2+kW14KV/v0zP4T8KpepvLyvFnTRrFDG7GMSk2vtkxhPwvuIO0TEWUl424Uz /8RZMcKLj5iZKdtgq9azQD7cmsDrQIriN3aqku5wibm3Z8b1Y3ysVOGDTUizW5avozVh JFhw== X-Gm-Message-State: AKwxytc7UCDTiKWXtIVrIb3uCVTvRzAeRt/ZH0N2PXcpyPvXmGuy7RXL DUrzpykAfg0y+TThJLgL7+zYr5Oouplj3K2VFzczow== X-Google-Smtp-Source: AH8x224sm1OiJrRjFnb6jtx/chM7SL4SvVIoJ7jTxpYIA7x7SR6Iesz3wcmiluC1MDnuFEh41nz5UN0HJEbNHVG7LF4= X-Received: by 10.200.8.87 with SMTP id x23mr27423425qth.182.1517005901897; Fri, 26 Jan 2018 14:31:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.4 with HTTP; Fri, 26 Jan 2018 14:31:11 -0800 (PST) In-Reply-To: <20180125141138.701802b4@ThinkPad> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <20180125141138.701802b4@ThinkPad> From: Omair Javaid Date: Fri, 26 Jan 2018 22:31:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver To: Philipp Rudo Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00568.txt.bz2 Hi Alan, I just ran gdb testsuite with native-gdbserver configuration on your patches and found a couple of regressions. At least first three seems to be coming out of your patch series as they seem persistent over multiple runs of testsuite. 1c1 < Test Run By omair on Sat Jan 27 02:51:24 2018 --- > Test Run By omair on Sat Jan 27 01:58:06 2018 1257,1258c1257,1258 < FAIL: gdb.arch/i386-mpx.exp: bndcfgu formating < FAIL: gdb.arch/i386-mpx.exp: test if bndstatus is enabled --- > PASS: gdb.arch/i386-mpx.exp: bndcfgu formating > PASS: gdb.arch/i386-mpx.exp: test if bndstatus is enabled 6706c6706 < FAIL: gdb.base/gcore.exp: corefile restored all registers --- > PASS: gdb.base/gcore.exp: corefile restored all registers 50790c50790 < PASS: gdb.threads/thread-unwindonsignal.exp: continue until exit --- > FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit (timeout) 55145,55146c55145,55146 < # of expected passes 51385 < # of unexpected failures 1249 --- > # of expected passes 51387 > # of unexpected failures 1247 On 25 January 2018 at 18:11, Philipp Rudo wrote: > Hi Alan, > > in general the series looks fine for me. Just some nits/suggestions. > > Philipp > > On Wed, 24 Jan 2018 09:26:10 +0000 > Alan Hayward wrote: > > > Following review comments from Yao, this patch series is mostly a > > reordering of the code from the previous patch series. > > > > This set of patches removes the need for gdbserver to ship the xml files > > in the binary for those targets that use new style target descriptions. > > > > In exisiting code, gdbserver uses C code auto generated from xml files to > > create target descriptions. When sending an xml description to GDB, it > > creates an xml containing just the name of the original xml file. > > Upon receipt, GDB reads and parses a local copy of xml file. > > > > With this new patch, we add common code that allows gdbserver and gdb > > to turn a C target description structure into xml. To do this we must > > first ensure that when gdbserver parses a target description it retains > > enough information to turn it back into xml. > > > > The second patch commonises tdesc_reg, the third patch commonises > > tdesc_feature and the fifth patch commonises the tdesc type structures. > > This enables gdbserver to store all required information about a target > > description. > > > > The sixth patch adds the xml printer. > > The other patches are clean up patches. > > > > Patches have been tested on a make check on x86 targets=all build with > > target board unix native-gdbserver. Also tested aarch64. Built for power > > (becuase it does not use new target descriptions), but am unable to test. > > In addition, patch four adds new test cases to unit test. > > > > Alan. > > > > > > gdb/Makefile.in | 1 - > > gdb/arch/tdesc.c | 425 ------------------------ > > gdb/arch/tdesc.h | 307 +----------------- > > gdb/features/aarch64-core.c | 2 +- > > gdb/features/aarch64-fpu.c | 2 +- > > gdb/features/i386/32bit-avx.c | 2 +- > > gdb/features/i386/32bit-avx512.c | 2 +- > > gdb/features/i386/32bit-core.c | 2 +- > > gdb/features/i386/32bit-linux.c | 2 +- > > gdb/features/i386/32bit-mpx.c | 2 +- > > gdb/features/i386/32bit-pkeys.c | 2 +- > > gdb/features/i386/32bit-sse.c | 2 +- > > gdb/features/i386/64bit-avx.c | 2 +- > > gdb/features/i386/64bit-avx512.c | 2 +- > > gdb/features/i386/64bit-core.c | 2 +- > > gdb/features/i386/64bit-linux.c | 2 +- > > gdb/features/i386/64bit-mpx.c | 2 +- > > gdb/features/i386/64bit-pkeys.c | 2 +- > > gdb/features/i386/64bit-segments.c | 2 +- > > gdb/features/i386/64bit-sse.c | 2 +- > > gdb/features/i386/x32-core.c | 2 +- > > gdb/features/tic6x-c6xp.c | 2 +- > > gdb/features/tic6x-core.c | 2 +- > > gdb/features/tic6x-gp.c | 2 +- > > gdb/gdbserver/Makefile.in | 3 - > > gdb/gdbserver/configure.srv | 36 +++ > > gdb/gdbserver/tdesc.c | 229 +++++++------ > > gdb/gdbserver/tdesc.h | 58 +++- > > gdb/regformats/regdat.sh | 5 +- > > gdb/target-descriptions.c | 924 ++++++++++++++++++++++++++++++ > +++++++++-------------- > > gdb/xml-tdesc.c | 9 - > > gdb/xml-tdesc.h | 5 - > > 32 files changed, 920 insertions(+), 1124 deletions(-) > > > >