From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93421 invoked by alias); 24 Jan 2018 14:44:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89126 invoked by uid 89); 24 Jan 2018 14:44:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.0 required=5.0 tests=AWL,BAYES_00,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=orignal, eml, H*c:alternative, Hx-languages-length:5374 X-HELO: mail-qt0-f181.google.com Received: from mail-qt0-f181.google.com (HELO mail-qt0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 14:44:07 +0000 Received: by mail-qt0-f181.google.com with SMTP id s3so10806945qtb.10 for ; Wed, 24 Jan 2018 06:44:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PAz0+Ne1SrzOc6RqAto71Picxiji8N7xQHC4evbTX+s=; b=fOWOIcnunLTtsCo0HTj+PoOo2t7D0iL1wlLsThcXW3L4Zj+NebYDkoMfwqrd8nBlQk NYfMVieHfxO6NkbWGxG+C3BxfBkG9YRO0W3E9r6IMP90EbF2Y9jgu1tDy+SnBGVgzLKl Mh/Wj+RuXP+6anyGqIZ2opzU55BbBG8CL2fpVvE6/eBJycGQF1HVC0s3dS4lsDyxbG09 4ZwycWb99+6wDRILGsdkFadJPI5sjIqk5LPlB5V/x2NUW0oq9BoJOHCsnrv3b4/RNHLa lYaW8cbLuqWl3/bwJzfBOp03NjQObc5LeSFihGr3DlHb5K6+B6oY2AwHetkJMn4uQG2X mdoA== X-Gm-Message-State: AKwxyteKrn0r3uLpD7kIoqgh98O5rH4pQw15EKDap8rr5QMstUklTf+S UotBtkVeeKc7ZyFjSGaia8ABdmvKKJyldewt8PAUrtjJ X-Google-Smtp-Source: AH8x225TKfQUPfT2ZLA6y0HZydg+2WR165rLCRi3H9qaJMzrt8UWGj6/7HpqN2sFv4wNBo77Y4iqnkUBzx07ZsyObgE= X-Received: by 10.55.111.134 with SMTP id k128mr9937898qkc.175.1516805046074; Wed, 24 Jan 2018 06:44:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.33.46 with HTTP; Wed, 24 Jan 2018 06:43:35 -0800 (PST) In-Reply-To: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> From: Omair Javaid Date: Wed, 24 Jan 2018 14:44:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00474.txt.bz2 On 24 January 2018 at 17:29, Alan Hayward wrote: > > > On 24 Jan 2018, at 10:57, Omair Javaid wrote: > > > > Hi Alan, > > > > I am failing to apply your patch series to the latest gdb sources. > Apparently, your patch series needs a re-base over most recent gdb sources > as there has not been a commit since these patches have been posted. > > > > Generally its a good idea to generate patches using git format-patch and > send patches using git send-email. Patches need to be based off the most > recent gdb commit that is available at the time of sending them for revie= w. > If you use git format-patch to generate patches from your local commits it > would become very easy for a reviewer to just apply those patches using > "git apply" in their local branches. > > > > Kindly post a patchset that works with a known version of gdb sources in > order for your patches to be tested/reviewed upstream. > > > > That=E2=80=99s odd. > My patches were based off yesterday=E2=80=99s head (d820e164e4baccacd8d4e= 7e3761ec > 547402ae828). > I=E2=80=99ve just rebased my git to the latest head, and I got no conflic= ts or > merge warnings. > Looking at the diff from then until now, I can=E2=80=99t see any files th= at my > patch touches. > Happy to repost my rebased patches in the same way, but I suspect that=E2= =80=99s > not the issue. > > I=E2=80=99ve probably got something missing/wrong in the upper parts of o= f the > email. > > Were you having trouble with a particular patch or was it all of them? > Also, how are you getting the patch email from your email client to git? > I downloaded eml files. Also tried with untouched orignal email text. First 2 patches are applicable using git am. Third patch and onwards fail. With git apply or patch command even first patch fails. > > I=E2=80=99m sending mails by opening my mail client, writing my comments,= then > copy/pasting the contents > of a diff downloaded from a local reviewboard. That diff looks identical > to a git format-patch or git diff. > I=E2=80=99ve tried applying the first patch of the series to the latest h= ead using > both my patch file and contents > of the email, and both work for me. > I am not sure what exactly could be wrong but it could be email client mangling patch email or wrapping text or converting tabs/spaces. I think you are using a windows based email client which is using CR+LF as end line character which is incompatible with unix LF. > > I=E2=80=99ve just tested git send-mail, and it looks like I need to do so= me > messing around to get that working. > I can look at getting that working. > > In the meantime, I=E2=80=99ve pushed this branch to gdb with all my commi= ts: > remotes/origin/users/ahayward/xml > > Thanks, > Alan.