Re: [PATCH] [PR gdb/21695] Fix lost line info for symbol at addr zero

[Omair Javaid <omair.javaid@linaro.org>]

On Thu, 21 Jun 2018 at 23:26, Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> I have added Tom Tromey in CC, he is currently playing with storing
> Simon> symbols relocated vs unrelocated, so maybe he knows better.  And maybe
> Simon> there's something in his pending patches that also touch this area.
>
> The patch seems reasonable to me.
>
> I think it may touch the same code as my line table series, but that's
> no big deal.  I'll rebase when the time comes.
>
> >> +                                   CORE_ADDR lowpc_minus_base, CORE_ADDR address)
>
> Simon> I would suggest naming this "unrelocated_lowpc".  Can you update the
> Simon> documentation of the method to describe that parameter?
>
> Agreed.
>
> >> /* If address < lowpc then it's not a usable value, it's outside the
> >> pc range of the CU.  However, we restrict the test to only
>
> This comment could also use an update, and it should be using upper-case
> like "ADDRESS" and "LOWPC".
>
> Tom
Thanks Tom and Simon for review. I will send an update after fixing
highlighted issues.