From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120005 invoked by alias); 25 Jun 2018 10:11:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119991 invoked by uid 89); 25 Jun 2018 10:11:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=D*ca, H*Ad:D*ca, Marchi, marchi X-HELO: mail-qt0-f169.google.com Received: from mail-qt0-f169.google.com (HELO mail-qt0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jun 2018 10:11:22 +0000 Received: by mail-qt0-f169.google.com with SMTP id y31-v6so11393349qty.9 for ; Mon, 25 Jun 2018 03:11:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=awTRwYFi2/muZTFG9WEOh3jt/WMkf5pdBAuYp1QiW7A=; b=kzFI9QJGgtHWW8Qhb/Lh2ADvAkHBeNm/o8edJHh9RxTVEZTtQyjtU96V3h+pDcU92J qdod+j8XWl9CJgJT/zk578M83/Pp/kmWBMUhyGFE5KPTX+ry/KwHljLt4EKBzOkUa9iB ERlsfur94FI+pcdRtXLmIoZp7vmuo5ginTF8Hvmy3nkrAbzQDE58A4HhRA6A9FDy4e+A 8N3wFIuJSfEjvAgPASuIdSEpZqO+Fcc1kolvcJo2g3VD5uGFVMqH3NtfVXpG6oJFTTy/ 9KrVhpxRe/ekJ1u9xnRhdzrHHUrsrduU382HD+NKOIgrXP5aPg9whUL6aJi8L/6d76ei UM0g== X-Gm-Message-State: APt69E26BpBFB7lnNaQUmxu2fuNda1InTVcD6a2PInW1vhiHBLiHwacq cKZLsJSynb7ZHZsfqYnby0I5px11+9ndx/mbLAqseLroF24= X-Google-Smtp-Source: AAOMgpcWsFlbvyoZigWYQzAMM0uSdf6GmAwa2lO0J0fhlwsqm3ftyQdvJm7qFkVrxblbEumhMeeWwHV47Z/BNDcjWDI= X-Received: by 2002:a0c:c505:: with SMTP id x5-v6mr6313508qvi.206.1529921480516; Mon, 25 Jun 2018 03:11:20 -0700 (PDT) MIME-Version: 1.0 References: <1526393061-18039-1-git-send-email-omair.javaid@linaro.org> <87602cov18.fsf@tromey.com> In-Reply-To: <87602cov18.fsf@tromey.com> From: Omair Javaid Date: Mon, 25 Jun 2018 10:11:00 -0000 Message-ID: Subject: Re: [PATCH] [PR gdb/21695] Fix lost line info for symbol at addr zero To: Tom Tromey Cc: simon.marchi@polymtl.ca, GDB Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00570.txt.bz2 On Thu, 21 Jun 2018 at 23:26, Tom Tromey wrote: > > >>>>> "Simon" == Simon Marchi writes: > > Simon> I have added Tom Tromey in CC, he is currently playing with storing > Simon> symbols relocated vs unrelocated, so maybe he knows better. And maybe > Simon> there's something in his pending patches that also touch this area. > > The patch seems reasonable to me. > > I think it may touch the same code as my line table series, but that's > no big deal. I'll rebase when the time comes. > > >> + CORE_ADDR lowpc_minus_base, CORE_ADDR address) > > Simon> I would suggest naming this "unrelocated_lowpc". Can you update the > Simon> documentation of the method to describe that parameter? > > Agreed. > > >> /* If address < lowpc then it's not a usable value, it's outside the > >> pc range of the CU. However, we restrict the test to only > > This comment could also use an update, and it should be using upper-case > like "ADDRESS" and "LOWPC". > > Tom Thanks Tom and Simon for review. I will send an update after fixing highlighted issues.