Re: [RFC PATCH 0/6] Support for Linux kernel thread aware debug

[Omair Javaid <omair.javaid@linaro.org>]

On Tue, 29 Jan 2019 at 22:30, John Baldwin <jhb@freebsd.org> wrote:
>
> On 1/28/19 9:03 PM, Omair Javaid wrote:
> > This patch series implements linux kernel target which allows linux kernel
> > tasks to be viewed as GDB threads. We have had multiple set of patches
> > submitted over last few years aiming to insert add-ons into GDB for debugging
> > Linux kernel. This patch series builds on top of Linux kernel infrastructure
> > submitted by Philipp Rudo in his various sets of patches aiming to debug
> > Linux kernel dumps.
>
> I just have one minor suggestion / comment about file names.  I maintain
> FreeBSD kernel patches for gdb out-of-tree (for various reasons), and those
> patches use some similar things (e.g. a different OSABI).  My comment has
> to do with the filenames.  Other osabi-specific files tend to use more
> verbose names such as 'linux-arm-nat.c'.  I wonder if it makes sense to
> spell out linux here as well.  I have been using 'arm-fbsd-kern.c' as a
> complement to 'arm-fbsd-tdep.c' for the kernel gdbarch.  The architecture
> independent files follow the patter 'fbsd-k*.c' (e.g. fbsd-kld.c for modules
> and fbsd-kthr.c for thread enumeration), but I would be happy to move those
> to something like 'fbsd-kern-ld.c' and 'fbsd-kern-thr.c'.  For your current
> patchset that might mean something like 'linux-kern-tdep.c' instead of
> 'lk-tdep.c'.  I would also be fine with 'arm-linux-kern-tdep.c' instead of
> 'arm-linux-kern.c' perhaps if other folks feel like that is more consistent.

Hi John,

Andreas has aptly described the reason behind choosing the
nomenclature of new linux kernel specific files as it is right now and
i am open to any suggestion that my come up during reviews.

Also I was wondering if you can share details of kernel debugging
features which has implemented in your out of tree FreeBSD patches for
GDB. Also share some insight on ways to test this patchset.

Thanks!

>
> --
> John Baldwin
>
>