public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Omair Javaid <omair.javaid@linaro.org>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
Date: Wed, 11 Jun 2014 07:11:00 -0000	[thread overview]
Message-ID: <CANW4E-3YCXihEwozYx7b7UPn9kv8fNYjYAapr5xoAhi6RBT3pw@mail.gmail.com> (raw)
In-Reply-To: <87tx7y3u9b.fsf@br87z6lw.de.ibm.com>

On 6 June 2014 20:58, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> On Wed, Jun 04 2014, Omair Javaid wrote:
>
>> This patch adds support for recording system call instruction on aarch64-linux
>> targets.
>>
>> [...]
>> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> [...]
>> +
>> +  aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
>> +  aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
>> +  aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
>> +  aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>
> Is this a typo?  Otherwise the reason for this specialty should be
> documented in a comment here, IMO.
>
After a bit of digging up found out that AArch64 system calls take
between 0 and 7 arguments in register x1 to x7. I will update this
change with comment in upcoming update to this patch.

  reply	other threads:[~2014-06-11  7:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support " Omair Javaid
2014-06-04 16:21 ` [PATCH 1/7] NEWS entry about aarch64-linux record/replay support Omair Javaid
2014-06-04 16:24   ` Eli Zaretskii
2014-08-30  2:40   ` Yao Qi
2014-09-01 14:51     ` Marcus Shawcroft
2014-09-02  1:01       ` Yao Qi
2014-09-17 23:30         ` [PATCH] " Omair Javaid
2014-09-18  2:53           ` Eli Zaretskii
2014-06-04 16:21 ` [PATCH 6/7] Support for recording aarch64 advance simd instructions Omair Javaid
2014-06-05  8:58   ` Will Newton
2014-08-29 13:41     ` [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions Omair Javaid
2014-09-02 15:01       ` Will Newton
2014-06-04 16:21 ` [PATCH 3/7] Enable gdb process record on aarch64-linux targets Omair Javaid
2014-06-05  9:00   ` Will Newton
2014-08-30  3:35   ` Yao Qi
2014-09-01 19:50     ` Omair Javaid
2014-06-04 16:21 ` [PATCH 5/7] Support for recording syscall on aarch64-linux Omair Javaid
2014-06-05  8:52   ` Will Newton
2014-06-06 15:58   ` Andreas Arnez
2014-06-11  7:11     ` Omair Javaid [this message]
2014-08-29 11:53       ` Omair Javaid
2014-09-18  0:23         ` Will Newton
2014-09-18 22:28           ` Omair Javaid
2014-10-14 12:47             ` Omair Javaid
2014-10-21  9:09               ` Omair Javaid
2014-06-04 16:21 ` [PATCH 2/7] Fixes for aarch64-linux gdb core file support Omair Javaid
2014-06-04 17:11   ` Andreas Arnez
2014-06-05 17:09     ` Omair Javaid
2014-08-28 13:49       ` [PATCH 2/7] Fixes for aarch64-linux " Omair Javaid
2014-08-30  3:00         ` Yao Qi
2014-09-01 19:38           ` Omair Javaid
2014-09-17 23:37             ` Re " Omair Javaid
2014-10-14 12:49               ` Omair Javaid
2014-10-21  9:07                 ` Omair Javaid
2014-10-21 13:28         ` Yao Qi
2014-10-27 12:33           ` Omair Javaid
2014-06-05  9:07   ` [PATCH 2/7] Fixes for aarch64-linux gdb " Will Newton
2014-06-04 16:21 ` [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets Omair Javaid
2014-06-05  9:00   ` Will Newton
2014-10-21  9:10     ` Omair Javaid
2014-06-04 16:21 ` [PATCH 4/7] Implements aarch64 process record and reverse debugging support Omair Javaid
2014-06-05  8:34   ` Will Newton
2014-08-28 22:17     ` Omair Javaid
2014-08-30  3:27   ` Yao Qi
2014-09-01 20:08     ` Omair Javaid
2014-09-18  0:09       ` Omair Javaid
2014-09-18 22:29         ` Omair Javaid
2014-10-14 12:48           ` Omair Javaid
2014-10-21  9:08             ` Omair Javaid
2014-06-23 10:41 ` [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
2014-08-30  3:45 ` Yao Qi
2014-09-01 19:42   ` Omair Javaid
2014-09-02  1:12     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANW4E-3YCXihEwozYx7b7UPn9kv8fNYjYAapr5xoAhi6RBT3pw@mail.gmail.com \
    --to=omair.javaid@linaro.org \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).