From: Vasili Burdo <vasili.burdo@gmail.com>
To: Vasili Burdo via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] TUI disassembly window improvement - patch inline
Date: Wed, 9 Jun 2021 20:36:57 +0300 [thread overview]
Message-ID: <CANacp60n3xArhEDz0UJGwzJhizeRKtYHdC+KJx7je21JP00Nig@mail.gmail.com> (raw)
In-Reply-To: <878s3jjd3j.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
Hi, Tom
>Also, if you do not have a copyright assignment
I don't. What should I do to get it?
>Currently, patches require a ChangeLog entry.
All your patch-related comments are addressed.
Please review the patch in attachment.
>This is "PR tui/25347"
I marked my ChangeLog entry with this PR.
>Your mailer seems to have mangled the patch.
Now, I put the patch into the attachment.
>I wonder if the title setting is correct here.
Please, look at the screenshot in attachment.
The screen now looks like this:
+--funcaname2--------- <-- function name being executed, otherwise empty.
| funcname: <--- always on the first line.
| address <+255> insn <-- line format <address>
<+offset-from-the-func-start> <insn>
| address <+265> insn
| address <+270> insn
| funcaname2:
| address <+0> insn
| > [address <+5> insn] <-- the line being executed.
| address <+10> insn
+----------------------
Thanks, Vasili
[-- Attachment #2: gdb-asm-new-2.png --]
[-- Type: image/png, Size: 49653 bytes --]
[-- Attachment #3: vburdo-tui-asm.patch --]
[-- Type: application/x-patch, Size: 5842 bytes --]
prev parent reply other threads:[~2021-06-09 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:21 Vasili Burdo
2021-06-09 15:02 ` Tom Tromey
2021-06-09 17:36 ` Vasili Burdo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANacp60n3xArhEDz0UJGwzJhizeRKtYHdC+KJx7je21JP00Nig@mail.gmail.com \
--to=vasili.burdo@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).