From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by sourceware.org (Postfix) with ESMTPS id 7B7BD395C832 for ; Wed, 9 Jun 2021 12:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B7BD395C832 Received: by mail-vs1-xe31.google.com with SMTP id y207so4413643vsy.12 for ; Wed, 09 Jun 2021 05:56:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HX5Vyq2lJO+pGGKBEB4mkTE9kkPVeYRWk/nYXexCGN4=; b=BImaPcWYC+fJVNEkZT08VC/3ej9AKlqmlboYdxIqzaC/hJxLP6e2da6P9EUBrzbQPd 4Jpao17rBroWgBypV0MO7FDitswfgMzMo5OXyPxzLC8cd00cp4uELpu33cFmxKgVTGux SFJ05o9CNj5ZHzbkhbjMDCEL11MeGQHJfX5GTR28Z0CSrJSqDQddydphj6YWx2Xcl52g LAXYHkMG/4ytQBKa8fz254+Us9sSNbawCjmTE4UYoO11XFyzQmUUaOpWImK77O8mIhOP ThqXTehiVAPllIeI27eujdz6AKI03Big6S826wc9cnLGVXQIGPUI1Suufl6kRZ/JwiCy uI3A== X-Gm-Message-State: AOAM5300H5SC/hX5iLrT1tl4vfR6PvLDEex8zD9gVXeKf5vaAXnkmf1g Xtxo0DnsEViSpX52Nww/V9AOBJ10cD6nAdazn5A= X-Google-Smtp-Source: ABdhPJxIgc9iWLEVj5wGXOs/nr2/KehmHRB6OdpekIPjdb4bbdHYQ4MWhmrqCzUq6gPSiXtI11uwNe6QCDKI5y2CZX4= X-Received: by 2002:a67:7c95:: with SMTP id x143mr1190516vsc.46.1623243409759; Wed, 09 Jun 2021 05:56:49 -0700 (PDT) MIME-Version: 1.0 References: <831r9bdxpj.fsf@gnu.org> In-Reply-To: <831r9bdxpj.fsf@gnu.org> From: Vasili Burdo Date: Wed, 9 Jun 2021 15:56:38 +0300 Message-ID: Subject: Re: [PATCH] TUI disassembly window improvemenmt To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 12:56:51 -0000 Hi, Eli =D1=81=D1=80, 9 =D0=B8=D1=8E=D0=BD. 2021 =D0=B3. =D0=B2 15:33, Eli Zaretski= i : > > > Date: Tue, 8 Jun 2021 19:16:20 +0300 > > From: Vasili Burdo via Gdb-patches > > > > I implemented a small update to TUI disassembly window - see attachment= . > > This patch removes function name from disassembly listing leaving only > > offset from function start. > > The reason for it - disassembly TUI is almost unusable in case of C++ > > functions - their names (especially templated ones) are very long and > > thus litter disassembly view. > > Shouldn't this be optional behavior? Not everyone disassembles only > C++ code. This patch does not limit disassembly view in any way. - The current function name moved from disassembly line to window header - Offset from function start still present in disassembly line - Function start is marked by function name label. Hence, I don't see any reason to keep previous view style. Long function names may exist in any programming language, C++ is just a language where this problem w/ disassembly view is most annying.