From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 3E6F2385781A for ; Tue, 8 Jun 2021 16:16:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E6F2385781A Received: by mail-ua1-x930.google.com with SMTP id z13so6802377uai.12 for ; Tue, 08 Jun 2021 09:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8SUmHAKiqBbRBiPxKupekVCd19w9ATC+oIpD3fbHWiM=; b=fZjtyCGH1NYBtapc6xajMthSY8Kk34LUc/cbGidrjxXyPOtij+07xPlH5mwnxSeOGF 37jvR13dFOc3V1BRSnZc4W2t27qrTFFnpPqWInvm4zE9qpcmEaSA1Ta2ir57Ld2CT2lV +klKO5sFnwVl+4dmUIhe0mLJqB7ejSeY1i1gP+qlqUVRmxUKNkTwETkpZT14mLi1rZsS wXVGIARwcioe0qK4QqrYea2U2jJxxZC0cCHdYmo4e85FhGd8v17xWLYmcpLwkCaviKNf SGy6N2Qt1kKCTgvh+8vOE5uGaQw798hG7KJEEyc8EpMXGUcNLXqIkoRCmu1yWp8lHAyn lTNQ== X-Gm-Message-State: AOAM530Y4b7iUV/8DQ7bdByeHOOJi7V74k5OO6WSS/U+PwU+YO4K9EB8 WINa40TPnu2B+dbPFyIoQoAPDU0qQ/KOHjXuB9c+qeOTp2d5rQ== X-Google-Smtp-Source: ABdhPJz7B0QrN4ehoK30LI19OybN3WJbubIpoDfhB8UW3r7BjkXUpQ5ECimhADZY/EM/BTQfsPpobWeaHmbsZlFYtHY= X-Received: by 2002:ab0:484b:: with SMTP id c11mr4186914uad.100.1623168991610; Tue, 08 Jun 2021 09:16:31 -0700 (PDT) MIME-Version: 1.0 From: Vasili Burdo Date: Tue, 8 Jun 2021 19:16:20 +0300 Message-ID: Subject: [PATCH] TUI disassembly window improvemenmt To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="00000000000027e33605c4437b2c" X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 16:16:34 -0000 --00000000000027e33605c4437b2c Content-Type: text/plain; charset="UTF-8" Hi, I implemented a small update to TUI disassembly window - see attachment. This patch removes function name from disassembly listing leaving only offset from function start. The reason for it - disassembly TUI is almost unusable in case of C++ functions - their names (especially templated ones) are very long and thus litter disassembly view. Please, look at sample screenshots here: https://imgur.com/a/GlkVXGi Thanks, Vasili --00000000000027e33605c4437b2c Content-Type: text/x-patch; charset="US-ASCII"; name="vburdo-tui-asm.patch" Content-Disposition: attachment; filename="vburdo-tui-asm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kpo8q5861 ZGlmZiAtLWdpdCBhL2dkYi90dWkvdHVpLWRpc2FzbS5jIGIvZ2RiL3R1aS90dWktZGlzYXNtLmMK aW5kZXggMTYzNTUyYWVkZTQuLmU2ZGRmY2Q5MGNjIDEwMDY0NAotLS0gYS9nZGIvdHVpL3R1aS1k aXNhc20uYworKysgYi9nZGIvdHVpL3R1aS1kaXNhc20uYwpAQCAtMjcsNiArMjcsNyBAQAogI2lu Y2x1ZGUgInZhbHVlLmgiCiAjaW5jbHVkZSAic291cmNlLmgiCiAjaW5jbHVkZSAiZGlzYXNtLmgi CisjaW5jbHVkZSAidmFscHJpbnQuaCIKICNpbmNsdWRlICJ0dWkvdHVpLmgiCiAjaW5jbHVkZSAi dHVpL3R1aS1jb21tYW5kLmgiCiAjaW5jbHVkZSAidHVpL3R1aS1kYXRhLmgiCkBAIC00OCw2ICs0 OSw3IEBAIHN0cnVjdCB0dWlfYXNtX2xpbmUKIHsKICAgQ09SRV9BRERSIGFkZHI7CiAgIHN0ZDo6 c3RyaW5nIGFkZHJfc3RyaW5nOworICBzdGQ6OnN0cmluZyBmdW5jX3N0cmluZzsKICAgc2l6ZV90 IGFkZHJfc2l6ZTsKICAgc3RkOjpzdHJpbmcgaW5zbjsKIH07CkBAIC0xMDEsNyArMTAzLDggQEAg c3RhdGljIENPUkVfQUREUgogdHVpX2Rpc2Fzc2VtYmxlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJj aCwKIAkJIHN0ZDo6dmVjdG9yPHR1aV9hc21fbGluZT4gJmFzbV9saW5lcywKIAkJIENPUkVfQURE UiBwYywgaW50IGNvdW50LAotCQkgc2l6ZV90ICphZGRyX3NpemUgPSBudWxscHRyKQorCQkgc2l6 ZV90ICphZGRyX3NpemUgPSBudWxscHRyLAorCQkgYm9vbCBmb3JfdWkgPSBmYWxzZSkKIHsKICAg Ym9vbCB0ZXJtX291dCA9IHNvdXJjZV9zdHlsaW5nICYmIGdkYl9zdGRvdXQtPmNhbl9lbWl0X3N0 eWxlX2VzY2FwZSAoKTsKICAgc3RyaW5nX2ZpbGUgZ2RiX2Rpc19vdXQgKHRlcm1fb3V0KTsKQEAg LTExMCw3ICsxMTMsNyBAQCB0dWlfZGlzYXNzZW1ibGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LAogICBhc21fbGluZXMuY2xlYXIgKCk7CiAKICAgLyogTm93IGNvbnN0cnVjdCBlYWNoIGxpbmUu ICAqLwotICBmb3IgKGludCBpID0gMDsgaSA8IGNvdW50OyArK2kpCisgIHdoaWxlIChhc21fbGlu ZXMuc2l6ZSgpIDwgY291bnQpCiAgICAgewogICAgICAgdHVpX2FzbV9saW5lIHRhbDsKICAgICAg IENPUkVfQUREUiBvcmlnX3BjID0gcGM7CkBAIC0xMzUsOCArMTM4LDQ1IEBAIHR1aV9kaXNhc3Nl bWJsZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAKICAgICAgIC8qIEFuZCBjYXB0dXJlIHRo ZSBhZGRyZXNzIHRoZSBpbnN0cnVjdGlvbiBpcyBhdC4gICovCiAgICAgICB0YWwuYWRkciA9IG9y aWdfcGM7Ci0gICAgICBwcmludF9hZGRyZXNzIChnZGJhcmNoLCBvcmlnX3BjLCAmZ2RiX2Rpc19v dXQpOwotICAgICAgdGFsLmFkZHJfc3RyaW5nID0gc3RkOjptb3ZlIChnZGJfZGlzX291dC5zdHJp bmcgKCkpOworICAgICAgaWYoZm9yX3VpKSAKKyAgICAgICAgeworICAgICAgICAgIHN0ZDo6c3Ry aW5nIG5hbWUsIGZpbGVuYW1lOworICAgICAgICAgIGludCB1bm1hcHBlZCA9IDAsIG9mZnNldCA9 IDAsIGxpbmUgPSAwOworICAKKyAgICAgICAgICBpZiAoMCA9PSBidWlsZF9hZGRyZXNzX3N5bWJv bGljIChnZGJhcmNoLCBvcmlnX3BjLCBhc21fZGVtYW5nbGUsIGZhbHNlLAorICAgICAgICAgICAg ICAgICAgJm5hbWUsICZvZmZzZXQsICZmaWxlbmFtZSwgJmxpbmUsICZ1bm1hcHBlZCkpCisgICAg ICAgICAgICB7CisgICAgICAgICAgICAgIGlmICgwID09IG9mZnNldCkKKyAgICAgICAgICAgICAg ICB7CisgICAgICAgICAgICAgICAgICB0dWlfYXNtX2xpbmUgdGFsMiA9IHRhbDsKKyAgICAgICAg ICAgICAgICAgIGZwdXRzX3N0eWxlZCAobmFtZS5jX3N0ciAoKSwgZnVuY3Rpb25fbmFtZV9zdHls ZS5zdHlsZSAoKSwgJmdkYl9kaXNfb3V0KTsKKyAgICAgICAgICAgICAgICAgIGZwdXRzX2ZpbHRl cmVkICgiOiIsICZnZGJfZGlzX291dCk7CisgICAgICAgICAgICAgICAgICB0YWwyLmZ1bmNfc3Ry aW5nID0gbmFtZTsKKyAgICAgICAgICAgICAgICAgIHRhbDIuYWRkcl9zdHJpbmcgPSBzdGQ6Om1v dmUgKGdkYl9kaXNfb3V0LnN0cmluZyAoKSk7CisgICAgICAgICAgICAgICAgICB0YWwyLmFkZHJf c2l6ZSA9IDA7CisgICAgICAgICAgICAgICAgICB0YWwyLmluc24uY2xlYXIgKCk7CisgICAgICAg ICAgICAgICAgICBnZGJfZGlzX291dC5jbGVhciAoKTsKKyAgCisgICAgICAgICAgICAgICAgICBh c21fbGluZXMucHVzaF9iYWNrIChzdGQ6Om1vdmUgKHRhbDIpKTsKKyAgICAgICAgICAgICAgICB9 CisgIAorICAgICAgICAgICAgICBmcHV0c19zdHlsZWQgKHBhZGRyZXNzIChnZGJhcmNoLCBvcmln X3BjKSwgYWRkcmVzc19zdHlsZS5zdHlsZSAoKSwgJmdkYl9kaXNfb3V0KTsKKyAgICAgICAgICAg ICAgZnB1dHNfZmlsdGVyZWQgKCIgPCIsICZnZGJfZGlzX291dCk7CisgICAgICAgICAgICAgIGlm ICh1bm1hcHBlZCkKKyAgICAgICAgICAgICAgICBmcHV0c19maWx0ZXJlZCAoIioiLCAmZ2RiX2Rp c19vdXQpOworICAgICAgICAgICAgICBmcHJpbnRmX3N0eWxlZCAoJmdkYl9kaXNfb3V0LCBhZGRy ZXNzX3N0eWxlLnN0eWxlKCksICIlK2QiLCBvZmZzZXQpOworICAgICAgICAgICAgICBpZiAodW5t YXBwZWQpCisgICAgICAgICAgICAgICAgZnB1dHNfZmlsdGVyZWQgKCIqIiwgJmdkYl9kaXNfb3V0 KTsKKyAgICAgICAgICAgICAgZnB1dHNfZmlsdGVyZWQgKCI+IiwgJmdkYl9kaXNfb3V0KTsKKyAg ICAgICAgICAgICAgdGFsLmFkZHJfc3RyaW5nID0gc3RkOjptb3ZlIChnZGJfZGlzX291dC5zdHJp bmcgKCkpOworICAgICAgICAgICAgICB0YWwuZnVuY19zdHJpbmcgPSBzdGQ6Om1vdmUgKG5hbWUp OworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICBlbHNlCisgICAgICAgIHsKKyAgICAg ICAgICBwcmludF9hZGRyZXNzIChnZGJhcmNoLCBvcmlnX3BjLCAmZ2RiX2Rpc19vdXQpOworICAg ICAgICAgIHRhbC5hZGRyX3N0cmluZyA9IHN0ZDo6bW92ZSAoZ2RiX2Rpc19vdXQuc3RyaW5nICgp KTsKKyAgICAgICAgfQogICAgICAgZ2RiX2Rpc19vdXQuY2xlYXIgKCk7CiAKICAgICAgIGlmIChh ZGRyX3NpemUgIT0gbnVsbHB0cikKQEAgLTM0Miw3ICszODIsMTIgQEAgdHVpX2Rpc2FzbV93aW5k b3c6OnNldF9jb250ZW50cyAoc3RydWN0IGdkYmFyY2ggKmFyY2gsCiAgIC8qIEdldCB0ZW1wb3Jh cnkgdGFibGUgdGhhdCB3aWxsIGhvbGQgYWxsIHN0cmluZ3MgKGFkZHIgJiBpbnNuKS4gICovCiAg IHN0ZDo6dmVjdG9yPHR1aV9hc21fbGluZT4gYXNtX2xpbmVzOwogICBzaXplX3QgYWRkcl9zaXpl ID0gMDsKLSAgdHVpX2Rpc2Fzc2VtYmxlIChtX2dkYmFyY2gsIGFzbV9saW5lcywgcGMsIG1heF9s aW5lcywgJmFkZHJfc2l6ZSk7CisgIHR1aV9kaXNhc3NlbWJsZSAobV9nZGJhcmNoLCBhc21fbGlu ZXMsIHBjLCBtYXhfbGluZXMsICZhZGRyX3NpemUsIHRydWUpOworCisgIC8qIFNldCB0aXRsZSB0 byBjdXJyZW50IGZ1bmN0aW9uIG5hbWUgKi8KKyAgdGl0bGUuY2xlYXIoKTsKKyAgaWYgKGFzbV9s aW5lcy5zaXplKCkpCisgICAgdGl0bGUgPSBhc21fbGluZXMuZnJvbnQoKS5mdW5jX3N0cmluZzsK IAogICAvKiBBbGlnbiBpbnN0cnVjdGlvbnMgdG8gdGhlIHNhbWUgY29sdW1uLiAgKi8KICAgaW5z bl9wb3MgPSAoMSArIChhZGRyX3NpemUgLyB0YWJfbGVuKSkgKiB0YWJfbGVuOwo= --00000000000027e33605c4437b2c--