Re: [PATCH] TUI disassembly window improvemenmt

[Vasili Burdo <vasili.burdo@gmail.com>]

Eli, please take look at screenshots I posted: https://imgur.com/a/GlkVXGi
They show disassembly starting from the same address.

>if some other function is referenced in the disassembly, it will now be invisible, right?
No. Only "address" part for disassembly line is changed. "insn" part
which contains references is intact.

>IOW, you seem to assume that any function names mentioned in the disassembly are always the name of the current function
I didn't make any assumptions of this kind.

ср, 9 июн. 2021 г. в 16:05, Eli Zaretskii <eliz@gnu.org>:
>
> > From: Vasili Burdo <vasili.burdo@gmail.com>
> > Date: Wed, 9 Jun 2021 15:56:38 +0300
> > Cc: gdb-patches@sourceware.org
> >
> > > Shouldn't this be optional behavior?  Not everyone disassembles only
> > > C++ code.
> > This patch does not limit disassembly view in any way.
> > - The current  function name moved from disassembly line to window header
> > - Offset from function start still present in disassembly line
> > - Function start is marked by function name label.
>
> But AFAIU only the current function's name is visible; if some other
> function is referenced in the disassembly, it will now be invisible,
> right?
>
> IOW, you seem to assume that any function names mentioned in the
> disassembly are always the name of the current function, but is that
> an assumption that is always correct?