From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 45981385503A for ; Wed, 9 Jun 2021 13:16:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45981385503A Received: by mail-ua1-x930.google.com with SMTP id n61so12854096uan.2 for ; Wed, 09 Jun 2021 06:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/EhhgRRCgz4M7sMU/2YiiOJ2tXACwvjhUAn4bx5mGqQ=; b=VvzdfAJjTIYNofMmhp5sSuh6tIjKUfpLi3qXUKycGDoSsqhGEtWkyBxsotZK4HKD5e pJNSE3plvxamJbPCnS/un4ZJvB7fHDdR1CZncB3zZa+hcxgEv6sCdeD4PH3l9KMX7i+q EViao/9dMuJOWzoPBs+ktxFNptyCpdZfQHydASVcKlKv2vvy7uFUUOFAvVuPW+UrFVj9 PnF6AODUuVbieHRGBJb/MpU/pkRh5r1ZbquKF3uqGfbBdteJXfxTQzTYDW1CWXRa1T42 +rvLWQOTlnXS5dtBpOU9UdOCRWhM4ZL3LZS0kjM6CPw3U4U5X6+CNjl1OUyhqQ4VtGUm V/HA== X-Gm-Message-State: AOAM531sGASgLfymmX3Bcix22jp5gKvPynY9qQqZ1Tfwkm+Mc4GA/N40 g2GLCv1yxUSTCb2y2VZ+hgOw+xmnLPLUjo4/A51BIotAd57JvJGC X-Google-Smtp-Source: ABdhPJyKjsjU7otKI9JoLGI+XfBs3UScfZKL9uY3D2JGiYbpzXvsjlXv2Iii2fC6MfUkAHqYVik3rbANtcvovShVqJw= X-Received: by 2002:ab0:6947:: with SMTP id c7mr16424153uas.116.1623244578892; Wed, 09 Jun 2021 06:16:18 -0700 (PDT) MIME-Version: 1.0 References: <831r9bdxpj.fsf@gnu.org> <83zgvzcho1.fsf@gnu.org> In-Reply-To: <83zgvzcho1.fsf@gnu.org> From: Vasili Burdo Date: Wed, 9 Jun 2021 16:16:08 +0300 Message-ID: Subject: Re: [PATCH] TUI disassembly window improvemenmt To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 13:16:22 -0000 Eli, please take look at screenshots I posted: https://imgur.com/a/GlkVXGi They show disassembly starting from the same address. >if some other function is referenced in the disassembly, it will now be in= visible, right? No. Only "address" part for disassembly line is changed. "insn" part which contains references is intact. >IOW, you seem to assume that any function names mentioned in the disassemb= ly are always the name of the current function I didn't make any assumptions of this kind. =D1=81=D1=80, 9 =D0=B8=D1=8E=D0=BD. 2021 =D0=B3. =D0=B2 16:05, Eli Zaretski= i : > > > From: Vasili Burdo > > Date: Wed, 9 Jun 2021 15:56:38 +0300 > > Cc: gdb-patches@sourceware.org > > > > > Shouldn't this be optional behavior? Not everyone disassembles only > > > C++ code. > > This patch does not limit disassembly view in any way. > > - The current function name moved from disassembly line to window head= er > > - Offset from function start still present in disassembly line > > - Function start is marked by function name label. > > But AFAIU only the current function's name is visible; if some other > function is referenced in the disassembly, it will now be invisible, > right? > > IOW, you seem to assume that any function names mentioned in the > disassembly are always the name of the current function, but is that > an assumption that is always correct?