From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27935 invoked by alias); 16 Jun 2014 07:27:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27923 invoked by uid 89); 16 Jun 2014 07:27:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f172.google.com Received: from mail-ie0-f172.google.com (HELO mail-ie0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Jun 2014 07:27:09 +0000 Received: by mail-ie0-f172.google.com with SMTP id lx4so4653551iec.3 for ; Mon, 16 Jun 2014 00:27:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=I47Q0SeLNYE9qQ5tYr8mDOGX0n8POt36ivGTuqSQb/w=; b=HXbLwWJBp+5zgw3sOsthNVx0fZHRcYX+58cdDGmIxWyiMbYjUE/smz0aQoYL//mMx1 HRSXsdgGjiONHWx/9ceUyhvcVHEvZBWIRei39AKxsPmq0NT79v7MsOHx2FaDBPUOJ8li PnJULYEqaqkgVUeflFnTJE4N90LzyiWUobQdU014JM3fQX76K+XMIPJpO8RTgjbECkzS K/ZvDZs63pA8gp9mp2bnmuxG4xTKrLJnmLPriX+IS5S717q4dowR/AA31RE5l+3bLi+w wMlLO1/4yXQ44YFQaXqK9i57RClpJ2ayDCklam2vZvVyBh9lO+Es1qxksozgu4lsy/GY tIgw== X-Gm-Message-State: ALoCoQm0VbVGQk69ardZlaCMpFLELO5FatIYZkibXTQMqg3XV00bWuXTSSdEh4Skic0L/4DslcJl MIME-Version: 1.0 X-Received: by 10.43.155.68 with SMTP id lh4mr18313057icc.30.1402903627334; Mon, 16 Jun 2014 00:27:07 -0700 (PDT) Received: by 10.64.225.50 with HTTP; Mon, 16 Jun 2014 00:27:07 -0700 (PDT) In-Reply-To: <000001cf8908$49f991f0$ddecb5d0$@arm.com> References: <000b01cf8540$dafa6d80$90ef4880$@arm.com> <001701cf8555$40925540$c1b6ffc0$@arm.com> <53983C82.4040208@codesourcery.com> <001801cf85ef$f9decd40$ed9c67c0$@arm.com> <000001cf8908$49f991f0$ddecb5d0$@arm.com> Date: Mon, 16 Jun 2014 07:27:00 -0000 Message-ID: Subject: Re: [Patch]Clean up the XML files for ARM From: Will Newton To: Terry Guo Cc: lgustavo@codesourcery.com, "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00546.txt.bz2 On 16 June 2014 03:11, Terry Guo wrote: > > >> -----Original Message----- >> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] On Behalf Of Terry Guo >> Sent: Thursday, June 12, 2014 11:40 AM >> To: lgustavo@codesourcery.com; 'Will Newton' >> Cc: gdb-patches@sourceware.org >> Subject: RE: [Patch]Clean up the XML files for ARM >> >> >> >> > -----Original Message----- >> > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> > owner@sourceware.org] On Behalf Of Luis Machado >> > Sent: Wednesday, June 11, 2014 7:25 PM >> > To: Terry Guo; 'Will Newton' >> > Cc: gdb-patches@sourceware.org >> > Subject: Re: [Patch]Clean up the XML files for ARM >> > >> > On 06/11/2014 10:12 AM, Terry Guo wrote: >> > > >> > > >> > >> -----Original Message----- >> > >> From: Will Newton [mailto:will.newton@linaro.org] >> > >> Sent: Wednesday, June 11, 2014 4:16 PM >> > >> To: Terry Guo >> > >> Cc: gdb-patches@sourceware.org >> > >> Subject: Re: [Patch]Clean up the XML files for ARM >> > >> >> > >> On 11 June 2014 07:46, Terry Guo wrote: >> > >>> Hi There, >> > >>> >> > >>> Under folder gdb/features we are having more and more ARM related >> > >>> XML >> > >> files. >> > >>> This patch intends to move those ARM XML files into a new folder >> > >>> named >> > >> arm. >> > >>> All the references to those files are now prefixed with folder name >> arm. >> > >>> Please be noted that this doesn't include AArch64 XML files so far. >> > >>> Is it ok to GDB trunk? >> > >>> >> > >>> BR, >> > >>> Terry >> > >>> >> > >>> 2014-06-11 Terry Guo >> > >>> >> > >>> * features/arm-core.xml: Move to ... >> > >>> * features/arm/arm-core.xml: ... here. >> > >>> * features/arm-fpa.xml: Move to ... >> > >>> * features/arm/arm-fpa.xml: ... here. >> > >>> * features/arm-m-profile.xml: Move to ... >> > >>> * features/arm/arm-m-profile.xml: ... here. >> > >>> * features/arm-vfpv2.xml: Move to ... >> > >>> * features/arm/arm-vfpv2.xml: ... here. >> > >>> * features/arm-vfpv3.xml: Move to ... >> > >>> * features/arm/arm-vfpv3.xml: ... here. >> > >>> * features/arm-with-iwmmxt.xml: Move to ... >> > >>> * features/arm/arm-with-iwmmxt.xml: ... here. >> > >>> * features/arm-with-iwmmxt.c: Move to ... >> > >>> * features/arm/arm-with-iwmmxt.c: ... here. >> > >>> * features/arm-with-m.xml: Move to ... >> > >>> * features/arm/arm-with-m.xml: ... here. >> > >>> * features/arm-with-m.c: Move to ... >> > >>> * features/arm/arm-with-m.c: ... here. >> > >>> * features/arm-with-m-fpa-layout.xml: Move to ... >> > >>> * features/arm/arm-with-m-fpa-layout.xml: ... here. >> > >>> * features/arm-with-m-fpa-layout.c: Move to ... >> > >>> * features/arm/arm-with-m-fpa-layout.c: ... here. >> > >>> * features/arm-with-m-vfp-d16.xml: Move to ... >> > >>> * features/arm/arm-with-m-vfp-d16.xml: ... here. >> > >>> * features/arm-with-m-vfp-d16.c: Move to ... >> > >>> * features/arm/arm-with-m-vfp-d16.c: ... here. >> > >>> * features/arm-with-neon.xml: Move to ... >> > >>> * features/arm/arm-with-neon.xml: ... here. >> > >>> * features/arm-with-neon.c: Move to ... >> > >>> * features/arm/arm-with-neon.c: ... here. >> > >>> * features/arm-with-vfpv2.xml: Move to ... >> > >>> * features/arm/arm-with-vfpv2.xml: ... here. >> > >>> * features/arm-with-vfpv2.c: Move to ... >> > >>> * features/arm/arm-with-vfpv2.c: ... here. >> > >>> * features/arm-with-vfpv3.xml: Move to ... >> > >>> * features/arm/arm-with-vfpv3.xml: ... here. >> > >>> * features/arm-with-vfpv3.c: Move to ... >> > >>> * features/arm/arm-with-vfpv3.c: ... here. >> > >>> * features/Makefile: Use new paths to refer ARM files. >> > >>> * arm-tdep.c: Use new paths to include files. >> > >> >> > >> It seems like we have duplicate "arm" in some of the names now, it >> > >> might be a good cleanup to rename, e.g.: >> > >> >> > >> features/arm/arm-vfpv3.xml -> features/arm/vfpv3.xml >> > >> >> > > >> > > Thanks for comments. But files in folder i386 and rs6000 are same as mine. >> > Maybe there are reasons to do so. >> > > >> > > For example: >> > > >> > > i386/ >> > > i386/i386-mmx.c >> > > i386/32bit-avx512.xml >> > > i386/x32-avx512.xml >> > > i386/x32-avx512-linux.c >> > > i386/32bit-sse.xml >> > > i386/32bit-mpx.xml >> > > i386/i386-avx-linux.xml >> > > i386/i386-mpx.c >> > > i386/i386-mpx-linux.xml >> > > i386/x32-core.xml >> > > i386/64bit-core.xml >> > > i386/i386.xml >> > > >> > > ./rs6000/powerpc-isa205-altivec64l.xml >> > > ./rs6000/powerpc-e500l.c >> > > ./rs6000/powerpc-altivec64l.c >> > > ./rs6000/powerpc-603.xml >> > > ./rs6000/powerpc-602.xml >> > > ./rs6000/power64-core.xml >> > > ./rs6000/powerpc-64.c >> > > ./rs6000/powerpc-altivec64.c >> > > ./rs6000/powerpc-505.xml >> > > >> > > BR, >> > > Terry >> > >> > I think one of the reasons for having duplication there is that nobody >> > commented about it, like Will. >> > >> > I'd go for the cleaner names without the duplication. The duplication >> certainly >> > doesn't add anything to it. >> > >> >> Hi Luis and Will, >> >> Thanks both of you. This clears my concerns. I will update this per your >> comments. >> >> BR, >> Terry >> >> > > Hi, > > Attachment is an updated patch with the removal of arm in filename. There is also a change to gdb regression test case. Is this one OK? > > BR, > Terry > > Updated ChangeLog: > > > 2014-06-16 Terry Guo > > * features/arm-core.xml: Move to ... > * features/arm/core.xml: ... here. > * features/arm-fpa.xml: Move to ... > * features/arm/fpa.xml: ... here. > * features/arm-m-profile.xml: Move to ... > * features/arm/m-profile.xml: ... here. > * features/arm-vfpv2.xml: Move to ... > * features/arm/vfpv2.xml: ... here. > * features/arm-vfpv3.xml: Move to ... > * features/arm/vfpv3.xml: ... here. > * features/arm-with-iwmmxt.xml: Move to ... > * features/arm/with-iwmmxt.xml: ... here. > * features/arm-with-iwmmxt.c: Move to ... > * features/arm/with-iwmmxt.c: ... here. > * features/arm-with-m.xml: Move to ... > * features/arm/with-m.xml: ... here. > * features/arm-with-m.c: Move to ... > * features/arm/with-m.c: ... here. > * features/arm-with-m-fpa-layout.xml: Move to ... > * features/arm/with-m-fpa-layout.xml: ... here. > * features/arm-with-m-fpa-layout.c: Move to ... > * features/arm/with-m-fpa-layout.c: ... here. > * features/arm-with-m-vfp-d16.xml: Move to ... > * features/arm/with-m-vfp-d16.xml: ... here. > * features/arm-with-m-vfp-d16.c: Move to ... > * features/arm/with-m-vfp-d16.c: ... here. > * features/arm-with-neon.xml: Move to ... > * features/arm/with-neon.xml: ... here. > * features/arm-with-neon.c: Move to ... > * features/arm/with-neon.c: ... here. > * features/arm-with-vfpv2.xml: Move to ... > * features/arm/with-vfpv2.xml: ... here. > * features/arm-with-vfpv2.c: Move to ... > * features/arm/with-vfpv2.c: ... here. > * features/arm-with-vfpv3.xml: Move to ... > * features/arm/with-vfpv3.xml: ... here. > * features/arm-with-vfpv3.c: Move to ... > * features/arm/with-vfpv3.c: ... here. > * features/xscale-iwmmxt.xml: Move to ... > * features/arm/xscale-iwmmxt.xml: ... here. > * features/Makefile: Use new paths to refer ARM files. > * arm-tdep.c: Use new paths to include files. > > gdb/gdbserver/ChangeLog: > > 2014-06-16 Terry Guo > > * configure.srv: Use new paths to refer ARM XML files. > > 2014-06-16 Terry Guo > > * gdb.xml/tdesc-regs.exp (arm): Use new path to refer ARM XML file. This looks ok to me. -- Will Newton Toolchain Working Group, Linaro