From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6976 invoked by alias); 18 Oct 2013 10:32:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6960 invoked by uid 89); 18 Oct 2013 10:32:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ie0-f175.google.com Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 18 Oct 2013 10:32:37 +0000 Received: by mail-ie0-f175.google.com with SMTP id aq17so6244992iec.34 for ; Fri, 18 Oct 2013 03:32:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tlvhPP6CMfq0wMe8sw2e5EXDcSho0+qvZhKXYvWrHIg=; b=CZM/00L5cS8pPdMcs497DOgQRAzeOkJ5+cOGbYu9KGI9nKsjxyYsExtwqdjr3Wtt0w Hg/5RG6FjJd0duGQUHPRTNowMBDZqIZu58IwPEYziCK6JX53kHlUjOgEbfEKvICKSwit rSZiR4DqkR6Z8hOo734kP9Cycla3DNaS3STelQHk3L+/MIJjUFK1iwlX4E9GDua2sYn+ 4Eqlad9GV1ydbCzy8NIb99yerkXEsBf/1Xg6GzG/2s4OfleLiXogHzRU4W6QZ/iXzHxo 8ISagx5d1CmMpdHTsNcWdS9CTGN0BFExtp4pWm6/mWXZCEaU0bDqrKthjgEAAJoJgG+g 4H2g== X-Gm-Message-State: ALoCoQnYkgGsvzhl6M3pJNQ3yz1g9gc/e+ADFPE6r/eo8b414OTMwY2r3qKuRkfdUj/gFFqZHf19 MIME-Version: 1.0 X-Received: by 10.42.18.136 with SMTP id x8mr1303381ica.11.1382092356042; Fri, 18 Oct 2013 03:32:36 -0700 (PDT) Received: by 10.64.20.52 with HTTP; Fri, 18 Oct 2013 03:32:35 -0700 (PDT) In-Reply-To: <1382032193-9115-1-git-send-email-tromey@redhat.com> References: <1382032193-9115-1-git-send-email-tromey@redhat.com> Date: Fri, 18 Oct 2013 10:32:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/9] share minimal symbols across objfiles From: Will Newton To: Tom Tromey Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00554.txt.bz2 On 17 October 2013 18:49, Tom Tromey wrote: > This patch series changes minimal symbols to be independent of the > program space, and then to be stored in the per-BFD object. That way, > they can be shared by all objfiles referring to a given BFD. This > saves memory, and, in the case of ELF, the time spent re-reading the > symbols. > > In order to make a minimal symbol independent of the program space, > the correct objfile offset must be applied when the symbol's address > is computed. This series achieves that by introducing a two-argument > form of SYMBOL_VALUE_ADDRESS (but done in a way to ensure that all > errors will be caught at compile time); more fully completing the > switchover to the use of bound minimal symbols; and finally by > changing the definition of the new macro to apply the offsets. > > This is an update of a patch series I sent earlier: > > https://sourceware.org/ml/gdb-patches/2011-12/msg00470.html > > This version differs from the above in that: > > * There are no FIXMEs left > * I updated all the minimal symbol readers > * The use of bound minimal symbols (and the earlier removal of > msymbol_objfile) solves any potential problem with dlmopen > * The earlier series to fix how sections are represented in symbols > removes the need for the old "index" patches > > I built and regtested this on x86-64 Fedora 18 (with the defaults and > with -gstabs+), PPC Linux (gcc110 in the compile farm), and AIX > (gcc111 in the compile farm). I also built it on Fedora 18 using the > mingw cross compiler. > > > Please note that, while I made my best effort to fix everything > properly, there's really quite a bit here I can't test. In > particular, I have no way to test most of the changes I made to the > various symbol readers, in patch #8. > > If you could, I'd ask that you please test or at least carefully > review the relevant bits there. I've pushed this branch to archer.git > tromey/split-objfile/msymbol-location-independence to make this > simpler. There are no new test failures on this branch for arm-linux. -- Will Newton Toolchain Working Group, Linaro