From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8385 invoked by alias); 26 Nov 2014 01:19:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8373 invoked by uid 89); 26 Nov 2014 01:19:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f53.google.com Received: from mail-la0-f53.google.com (HELO mail-la0-f53.google.com) (209.85.215.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 26 Nov 2014 01:19:41 +0000 Received: by mail-la0-f53.google.com with SMTP id gm9so1608857lab.26 for ; Tue, 25 Nov 2014 17:19:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iRc7AAIiH8z0pwQXjCo6MEdfuCIZbV/OE2a2k0ZFVMY=; b=D/BJnwxq8avoiGSfGwHZsiBOCPvOgQuwj4VFUwDYVrDohGbmHzvW/t9BNidHkzp9yZ XqCpSp5TwrVNs490dd9GFXDjZxDUtG+3vvawmOyNiRZo7noT31MkDf4maDYbSUfKh2ra qdpamaqNOXbnnXooAvKcBzA67x+RgBb7pI8yri0yzWaic5bEc0Kah6Fb/nfSxThE7weq KFOCOV8MQq6jzBclEOF4+X83d6E98TQOAee14GuMzzGIOLgE35vmk6nrjEy3qcmGCc7e okRSUBwbI680Vzgh0InQnWbyshLKMUfVoAGpjmn6fqDmFwVMMcL7nlbdvCpiQUa4RrT/ 5tGA== X-Gm-Message-State: ALoCoQkVzswcQRUhFL1sw2cxDJLaU5mw8NwDYBCQVjYc5c1rVeBTZrK6gxguZl8f6nzyyi1EKtda MIME-Version: 1.0 X-Received: by 10.112.14.69 with SMTP id n5mr31239047lbc.34.1416964777958; Tue, 25 Nov 2014 17:19:37 -0800 (PST) Received: by 10.112.59.129 with HTTP; Tue, 25 Nov 2014 17:19:37 -0800 (PST) In-Reply-To: <87k32jc96x.fsf@redhat.com> References: <1416944088-8750-1-git-send-email-martin.galvan@tallertechnologies.com> <87k32jc96x.fsf@redhat.com> Date: Wed, 26 Nov 2014 01:19:00 -0000 Message-ID: Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq(). From: Martin Galvan To: Sergio Durigan Junior Cc: gdb-patches , Daniel Gutson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-11/txt/msg00636.txt.bz2 On Tue, Nov 25, 2014 at 5:32 PM, Sergio Durigan Junior wrote: > > On Tuesday, November 25 2014, Martin Galvan wrote: > > > I noticed in frame_id_eq() we were checking for the "l" frame_id being = invalid twice instead of checking both "l" and "r", so I corrected it. > > Hi Martin, > > Thanks for the patch. I guess it is obvious enough that it could be > checked in without approval, but just to be safe, let's wait until a > maintainer approves it. Meanwhile... > > > gdb/ChangeLog: > > > > 2014-11-25 Martin Galvan > > > > * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID. > > The indentation of this ChangeLog entry is wrong. You must use TAB > instead of whitespaces to indent the "*" part. My mistake. Will remember that for any new patches I send :) --=20 Mart=C3=ADn Galv=C3=A1n Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211