From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17882 invoked by alias); 13 May 2015 21:05:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17873 invoked by uid 89); 13 May 2015 21:05:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-la0-f48.google.com Received: from mail-la0-f48.google.com (HELO mail-la0-f48.google.com) (209.85.215.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 13 May 2015 21:05:20 +0000 Received: by layy10 with SMTP id y10so40806930lay.0 for ; Wed, 13 May 2015 14:05:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=sTVn2uXRs9B0ibr1DV79TtuUETRdegjtvGx3wnNSriI=; b=I9WjoBMOruzQz/5Rk87t5z8qNzuMXESIYw6sMLe0AbtHDd+wnxCABNomUhGimpAqjO Dx/xbZ8pjsn3xp6/nbWqHu47bbVuM668ez4zA/bNZ+22NysEhOHvIGD/iOdDvfe24wxy /5ROv0RqEPKhsGAZoq5kgwOPOvC0oGQa3riUt+IaogxjhMPpw2Jwf0Gd/2cwvngOZAyp PVrIcHL1UiTMFmrO4+2xRz/em9YpxxDaoYis8qJYyFOGqYw1JzMTH/iBLBeg6Poxuuun 6sTncMWH+Yz9AVM/igJVWRGv1/qpUIUTotgs1k+3ww1Fr2nqTLsoTFr107up6IcrcG59 PB0g== X-Gm-Message-State: ALoCoQkLKfg4MOFczmTMP+P9pEbQsJeQqvEdG9IXaKU91Gt1PXIriv+wckkK38Wf+Tw2j/TfFPTq X-Received: by 10.112.61.136 with SMTP id p8mr561840lbr.107.1431551117085; Wed, 13 May 2015 14:05:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.71 with HTTP; Wed, 13 May 2015 14:04:36 -0700 (PDT) In-Reply-To: References: <1429802693-4582-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Wed, 13 May 2015 21:05:00 -0000 Message-ID: Subject: Re: [PING][PATCH] Fix PR gdb/17720 (Function names appear without namespace/class prefixes in backtrace for optimized code) To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-05/txt/msg00345.txt.bz2 On Wed, May 13, 2015 at 5:58 PM, Doug Evans wrote: > On Thu, Apr 23, 2015 at 8:52 AM, Doug Evans wrote: >> On Thu, Apr 23, 2015 at 8:24 AM, Martin Galvan >> wrote: >>> This bug was being caused by die_needs_namespace returning 0 for a DIE = whose tag was DW_TAG_inlined_subroutine. This meant that dwarf2_physname wo= uld simply return the DIE's name attribute (which in our case would be "met= hod"). Therefore, when new_symbol_full called SYMBOL_SET_NAMES, the linkage= name argument wasn't the demangled name as it should have. >>> >>> This patch adds a case which would return 1 for DW_TAG_inlined_subrouti= ne in die_needs_namespace. It's tested both for classes and namespaces. >>> >>> I have a company-wide copyright assignment. I don't have commit access,= though, so it would be great if anyone could commit this for me. >>> >>> gdb/ >>> 2015-04-23 Martin Galvan >>> >>> * dwarf2read.c (die_needs_namespace): Return 1 for >>> DW_TAG_inlined_subroutine. >>> >>> --- >>> gdb/dwarf2read.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >>> index f6b0c01..2bf3513 100644 >>> --- a/gdb/dwarf2read.c >>> +++ b/gdb/dwarf2read.c >>> @@ -8357,6 +8357,7 @@ die_needs_namespace (struct die_info *die, struct= dwarf2_cu *cu) >>> case DW_TAG_enumeration_type: >>> case DW_TAG_enumerator: >>> case DW_TAG_subprogram: >>> + case DW_TAG_inlined_subroutine: >>> case DW_TAG_member: >>> case DW_TAG_imported_declaration: >>> return 1; >> >> LGTM. >> I'll check it in. > > Committed. > > I forgot the extra step of setting the author correctly, but it's just > one line so I'm leaving it. Well, considering that it solves a quite important issue and it took me a really long time to find it, fix it, and then get it commited, it'd be nice of you if you could fix the author :)