From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19287 invoked by alias); 11 May 2015 19:48:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19253 invoked by uid 89); 11 May 2015 19:48:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-lb0-f173.google.com Received: from mail-lb0-f173.google.com (HELO mail-lb0-f173.google.com) (209.85.217.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 11 May 2015 19:48:29 +0000 Received: by lbcga7 with SMTP id ga7so101920994lbc.1 for ; Mon, 11 May 2015 12:48:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=ojcODd1fz4SmitDah8BjL9+ZPv5mmwZgqtbQRVDrr8g=; b=TnY80vseHGztiDx+ZnEqX9FMyvrxwPKyTrr3+31aqGi1giEVDoUipNM6iMGL4oS1m3 BYEYv0713rcBg9QdzqYLZ3qmKOr8IyFGIgSq/fYGsJne5Ntyy6GHdlG8B9ytiveO06cB Kg90h+pu0+ud/Qfg6xsWCWa/lT4HiqciDym7yAb6EdkaR86faPdsnq/L9R0uHP9fSyjO jND62xEHKWcxc9PHkqKR9WPcGCsnKzYTi7InYMQU1iZFznx0IBf7YLhZoZ8zLBLbEVR/ i5z8CD6T7wRav2YWWpI+9I6aI9P5s2PJkzWfZ3whLjnlTKGKugFClQ/Z0LGOU2P4TFCO TVmQ== X-Gm-Message-State: ALoCoQlrE3cFNibBqvv6Gw9QcDfi9hJuRUkelre1x4ZIQzGlZ85csh3im664UxyfOWxxztCPjIev X-Received: by 10.112.72.2 with SMTP id z2mr9135442lbu.39.1431373706254; Mon, 11 May 2015 12:48:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.52.71 with HTTP; Mon, 11 May 2015 12:47:45 -0700 (PDT) In-Reply-To: References: <1429802693-4582-1-git-send-email-martin.galvan@tallertechnologies.com> From: Martin Galvan Date: Mon, 11 May 2015 19:48:00 -0000 Message-ID: Subject: Re: [PING][PATCH] Fix PR gdb/17720 (Function names appear without namespace/class prefixes in backtrace for optimized code) To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-05/txt/msg00259.txt.bz2 Sorry to bother but I didn't see this committed in the gdb repository. I don't have write access, so could you please commit this for me? Thanks a lot! On Thu, Apr 23, 2015 at 12:52 PM, Doug Evans wrote: > On Thu, Apr 23, 2015 at 8:24 AM, Martin Galvan > wrote: >> This bug was being caused by die_needs_namespace returning 0 for a DIE w= hose tag was DW_TAG_inlined_subroutine. This meant that dwarf2_physname wou= ld simply return the DIE's name attribute (which in our case would be "meth= od"). Therefore, when new_symbol_full called SYMBOL_SET_NAMES, the linkagen= ame argument wasn't the demangled name as it should have. >> >> This patch adds a case which would return 1 for DW_TAG_inlined_subroutin= e in die_needs_namespace. It's tested both for classes and namespaces. >> >> I have a company-wide copyright assignment. I don't have commit access, = though, so it would be great if anyone could commit this for me. >> >> gdb/ >> 2015-04-23 Martin Galvan >> >> * dwarf2read.c (die_needs_namespace): Return 1 for >> DW_TAG_inlined_subroutine. >> >> --- >> gdb/dwarf2read.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >> index f6b0c01..2bf3513 100644 >> --- a/gdb/dwarf2read.c >> +++ b/gdb/dwarf2read.c >> @@ -8357,6 +8357,7 @@ die_needs_namespace (struct die_info *die, struct = dwarf2_cu *cu) >> case DW_TAG_enumeration_type: >> case DW_TAG_enumerator: >> case DW_TAG_subprogram: >> + case DW_TAG_inlined_subroutine: >> case DW_TAG_member: >> case DW_TAG_imported_declaration: >> return 1; > > LGTM. > I'll check it in.