public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Martin Galvan <martin.galvan@tallertechnologies.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode
Date: Thu, 12 Mar 2015 00:25:00 -0000	[thread overview]
Message-ID: <CAOKbPbbA9=PsB_D_qUvYV7kF3ZvM+pR5srmmO3-Oi8XtFSDw1Q@mail.gmail.com> (raw)
In-Reply-To: <21760.54598.126480.383468@ruffy2.mtv.corp.google.com>

On Wed, Mar 11, 2015 at 8:52 PM, Doug Evans <dje@google.com> wrote:
> LGTM, with two more nits.
> The ChangeLog entry > 80 char limit :-),
> and convention is to include the function name in the ChangeLog entry.
>
> E.g.,
>
> 2015-03-11  Martin Galvan  <martin.galvan@tallertechnologies.com>
>
>         * python/lib/gdb/printing.py (register_pretty_printer): Fix exception
>         when registering a global pretty-printer in verbose mode.
>
> No need to repost though.
> Ok to commit with that fixed.

Thanks a lot! I'll keep that in mind for any future patches.

  reply	other threads:[~2015-03-12  0:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 18:17 Martin Galvan
2015-03-11 23:52 ` Doug Evans
2015-03-12  0:25   ` Martin Galvan [this message]
2015-03-28 20:40   ` Martin Galvan
2016-01-01 11:33     ` Joel Brobecker
2016-01-02  1:09       ` Martin Galvan
2016-01-02  2:46         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOKbPbbA9=PsB_D_qUvYV7kF3ZvM+pR5srmmO3-Oi8XtFSDw1Q@mail.gmail.com' \
    --to=martin.galvan@tallertechnologies.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).