From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102051 invoked by alias); 12 Feb 2018 14:14:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102040 invoked by uid 89); 12 Feb 2018 14:14:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Feb 2018 14:14:31 +0000 Received: by mail-wm0-f42.google.com with SMTP id v123so10184797wmd.5 for ; Mon, 12 Feb 2018 06:14:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Vl6s03JN+/+XsjSOT0pcPD7dctvmISdqb2/fahVDKT8=; b=h+XDsk0FcV8RBff7SRalo3BPkL79QFu+Co0ADfc9LetYLVNWiFJ7fSaU22wmUxrSiC zFxR1M103OqqAPoPgajxa1NyxMy+Vyj/R9EksTtFJSdAyVKLCr80zF1cZEckwUv3gLXt iWkFvW+yrd7JSSJHt0TeOBT2wEbGuR9iOGlNXbAKShWQ2s5PSTxN1yeVI/oPPFOb/MTZ 7+okUyT/CBfeJd9cUTxj1ou7G87Iy0EggYFShZAbyo4JWa3aGaFf/ncpqzs1tGpG2tyW dvb8QIpvZSMiELEWlc4rU3rDyvrI8LWoNl/cZWj9+fYb8JHTT/lQ91GuSdX/jGxtCV11 oMNQ== X-Gm-Message-State: APf1xPDUcKGszCEgI+v4GK4hlmDRDLZCr4LKdPp2TxkJI+LHi9LdN0vq SLoqCyZG5U9Q42SYb1y4vxEAAkrQAx3Cvi0Tsi8= X-Google-Smtp-Source: AH8x225TZd8w4YJNCcxtfC/WR69MY7s5SWsyhDIGmTBCifiqzAz/FMWANuYNt7ILnaPr0ZwaYMa/BjsnaOxxIYGnCoI= X-Received: by 10.80.146.134 with SMTP id k6mr16103231eda.107.1518444869451; Mon, 12 Feb 2018 06:14:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.134.211 with HTTP; Mon, 12 Feb 2018 06:14:28 -0800 (PST) In-Reply-To: References: <20180204000647.19188-1-niteria@gmail.com> From: Bartosz Nitka Date: Mon, 12 Feb 2018 14:14:00 -0000 Message-ID: Subject: Re: [PATCH v3 0/1] Don't rewind PC for GHC generated frames To: Yao Qi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-02/txt/msg00169.txt.bz2 2018-02-12 13:50 GMT+00:00 Yao Qi : > If what you meant is DW_LNS_set_column, then, other compilers > also generates it, and GDB doesn't use it. I'm not familiar with DW_LNS_set_column, perhaps GHC can be made to use it. The current encoding is described in [1]. Based on my experimentation [2] lldb seems to understand it. Note LineEntry: [0x00000000004056f7-0x0000000000405720): /data/users/bnitka/tmp/fib.hs:3:9 there. The second number (9) is the column number. > Maybe, GDB can use > it in TUI mode, to blink on the right line and column, or GDB tells > MI front ends the column number so they can highlight accordingly. I'm not a regular user of TUI mode or other front ends, so this wouldn't be the priority for me. > What do you want to add to GDB? Using the example from the summary. Currently gdb shows: (gdb) bt #0 Main_zdwfib_info () at fib.hs:3 #1 Main_zdwfib_info () at fib.hs:4 #2 Main_zdwfib_info () at fib.hs:4 #3 Main_zdwfib_info () at fib.hs:4 I'd like it to show something like: (gdb) bt #0 Main_zdwfib_info () at fib.hs:3:9 #1 Main_zdwfib_info () at fib.hs:4:20 #2 Main_zdwfib_info () at fib.hs:4:20 #3 Main_zdwfib_info () at fib.hs:4:20 Similarly, currently when you do: (gdb) info line *f1_info Line 4 of "fib.hs" starts at address... I'd like to get: Line 4, column 20 of "fib.hs" starts at address... The ability to break on line + column would also be welcome, but it's not that important to me. [1] https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/debug-info.html?highlight=dw_tag_ghc_src_note#dw-tag-ghc-src-note [2] https://ghc.haskell.org/trac/ghc/wiki/DWARF#lldb