public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bartosz Nitka <niteria@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 0/1] Don't rewind PC for GHC generated frames
Date: Mon, 19 Feb 2018 13:27:00 -0000	[thread overview]
Message-ID: <CAOSxnRhgwzKxAggsMcLNdyus9+VxNDJ409qna6ebORVXW7Ojyw@mail.gmail.com> (raw)
In-Reply-To: <CAH=s-PO4U2J5Y-pLwxDMkEtj_SxWuqwSY24=AAUamFEaK+snBw@mail.gmail.com>

Hi Yao,

Thanks for taking a look.
I agree that GHC should use DW_LNS_set_column and I will try to see
what I can do about that.
My understanding is that DW_TAG_ghc_src_note was introduced because we
don't get enough
fidelity with DW_LNS_set_column. I think it's because we have ranges
for expression locations, and
sometimes the start points overlap, but I'm a bit hazy on the details.
I want to try DW_LNS_set_column and see how far I get with that.

One thing I don't understand is why lldb seems to understand
DW_TAG_ghc_src_note. I need to investigate a bit more.

Thanks,
Bartosz

      reply	other threads:[~2018-02-19 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-04  0:07 Bartosz Nitka
2018-02-04  0:07 ` [PATCH v3 1/1] " Bartosz Nitka
2018-02-12 12:35   ` Bartosz Nitka
2018-02-12 15:44   ` Simon Marchi
2018-02-19 13:10     ` Bartosz Nitka
2018-02-19 17:02       ` Simon Marchi
2018-02-12 13:50 ` [PATCH v3 0/1] " Yao Qi
2018-02-12 14:14   ` Bartosz Nitka
2018-02-12 14:42     ` Yao Qi
2018-02-19 13:27       ` Bartosz Nitka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOSxnRhgwzKxAggsMcLNdyus9+VxNDJ409qna6ebORVXW7Ojyw@mail.gmail.com \
    --to=niteria@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).