From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20935 invoked by alias); 19 Feb 2018 13:27:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18220 invoked by uid 89); 19 Feb 2018 13:27:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=fidelity X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Feb 2018 13:27:07 +0000 Received: by mail-wm0-f47.google.com with SMTP id x21so15022216wmh.0 for ; Mon, 19 Feb 2018 05:27:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jwcHQkdrkdq5N32LGCyWRuVOi2fWycuRhJgizKTTdho=; b=n3MmgPjSdQen2rXeVm0Gp2lOFaPJ8e2PJEQOdyiMc+9sb1SD3QoB0/qFThUYjB1rU0 IztrlSPvEu8yw84TCeTNUEkWXSCOdYY5fqjQrkjx7STCKMAg8TuCQD+7xUVq9uw0x97H kYdXC4og+uTl+FSwSDHuMvdlX26R9TXPTAjNzggqAaOYPPOFDUIf/7azcbdyd0sSSXm2 3zvmlRU6Xuq2K4mf8XeI0lvE2ANeMYtUYjdMfr/N+dV71OMucq2cai4PvJK781J2eyGY RBX2ImnP4V3EMtRolF4tMD1AOYzVdV6HMCgTJqM0eGfdv6iXXdFumQJ0JU5Z6aEQG+Au Lyjw== X-Gm-Message-State: APf1xPAJo1f+SaN0urVcEf6y+TK01xvTLsjujrEfDPL4iwxycqBPlYvZ RKfma/TQ6Cugt4wB1xlwrQt8NGv2WSNjI70K8J0= X-Google-Smtp-Source: AH8x224/5beTv0IxrZZ/Xjz/Yy1vAE1x31UyUt2cuo+MNN74Fd+ko3CDntEDPWLfXZQtqsL+EtfxQ67GVDoE2XjAUMM= X-Received: by 10.80.171.78 with SMTP id t14mr19913350edc.170.1519046825464; Mon, 19 Feb 2018 05:27:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.149.245 with HTTP; Mon, 19 Feb 2018 05:27:04 -0800 (PST) In-Reply-To: References: <20180204000647.19188-1-niteria@gmail.com> From: Bartosz Nitka Date: Mon, 19 Feb 2018 13:27:00 -0000 Message-ID: Subject: Re: [PATCH v3 0/1] Don't rewind PC for GHC generated frames To: Yao Qi Cc: GDB Patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-02/txt/msg00244.txt.bz2 Hi Yao, Thanks for taking a look. I agree that GHC should use DW_LNS_set_column and I will try to see what I can do about that. My understanding is that DW_TAG_ghc_src_note was introduced because we don't get enough fidelity with DW_LNS_set_column. I think it's because we have ranges for expression locations, and sometimes the start points overlap, but I'm a bit hazy on the details. I want to try DW_LNS_set_column and see how far I get with that. One thing I don't understand is why lldb seems to understand DW_TAG_ghc_src_note. I need to investigate a bit more. Thanks, Bartosz